Bug 127801 – EFL port should stop using COMPILE_ASSERT_MATCHING_ENUM macros

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Anders Carlsson]

Instead of having COMPILE_ASSERT_MATCHING_ENUM macros, WebKit EFL should have functions that can map between different types. For example:

inline WKSameDocumentNavigationType toAPI(SameDocumentNavigationType type)
{
    WKFrameNavigationType wkType = kWKSameDocumentNavigationAnchorNavigation;

    switch (type) {
    case SameDocumentNavigationAnchorNavigation:
        wkType = kWKSameDocumentNavigationAnchorNavigation;
        break;
    case SameDocumentNavigationSessionStatePush:
        wkType = kWKSameDocumentNavigationSessionStatePush;
        break;
    case SameDocumentNavigationSessionStateReplace:
        wkType = kWKSameDocumentNavigationSessionStateReplace;
        break;
    case SameDocumentNavigationSessionStatePop:
        wkType = kWKSameDocumentNavigationSessionStatePop;
        break;
    }
    
    return wkType;
}

This allows us to change the enum values in WebCore without breaking the builds.

[Ryuan Choi]

Created attachment 222561 [details]
Patch

[Anders Carlsson]

Comment on attachment 222561 [details]
Patch

Thanks a lot for doing this!

[WebKit Commit Bot]

Comment on attachment 222561 [details]
Patch

Clearing flags on attachment: 222561

Committed r163033: <http://trac.webkit.org/changeset/163033>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Gyuyoung Kim]

(In reply to comment #1)
> Created an attachment (id=222561) [details]
> Patch

Thanks Ryuan :)