Bug 127792 - [GTK] Gardening 28 Jan 2014
Summary: [GTK] Gardening 28 Jan 2014
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-28 13:43 PST by Carlos Alberto Lopez Perez
Modified: 2014-01-28 14:40 PST (History)
1 user (show)

See Also:


Attachments
Patch (8.79 KB, patch)
2014-01-28 13:43 PST, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (8.50 KB, patch)
2014-01-28 14:03 PST, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-01-28 13:43:08 PST
[GTK] Gardening 28 Jan 2014
Comment 1 Carlos Alberto Lopez Perez 2014-01-28 13:43:31 PST
Created attachment 222480 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2014-01-28 14:01:03 PST
Comment on attachment 222480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222480&action=review

> LayoutTests/ChangeLog:19
> +        * platform/gtk-wk2/TestExpectations:

ChangeLog format is a bit weird. It's strange to have the same file twice in the ChangeLog. Please review it.

> LayoutTests/platform/gtk-wk2/TestExpectations:359
>  

I would move this just after "webkit.org/b/97655 fast/css/style-scoped [ Failure ]" to make it clearer why it's marked as Pass.
Comment 3 Carlos Alberto Lopez Perez 2014-01-28 14:03:29 PST
Created attachment 222484 [details]
Patch
Comment 4 WebKit Commit Bot 2014-01-28 14:40:08 PST
Comment on attachment 222484 [details]
Patch

Clearing flags on attachment: 222484

Committed r162963: <http://trac.webkit.org/changeset/162963>
Comment 5 WebKit Commit Bot 2014-01-28 14:40:10 PST
All reviewed patches have been landed.  Closing bug.