Bug 127788 - WebKit2 View Gestures (Swipe): Encode snapshots as JPEG on some platforms
Summary: WebKit2 View Gestures (Swipe): Encode snapshots as JPEG on some platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
: 132844 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-28 12:46 PST by Tim Horton
Modified: 2014-05-13 14:36 PDT (History)
4 users (show)

See Also:

Attachments
patch (18.92 KB, patch)
2014-05-12 18:10 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
fix the iOS build (18.94 KB, patch)
2014-05-12 22:12 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-01-28 12:46:43 PST 
See http://trac.webkit.org/changeset/162950
Comment 1 Radar WebKit Bug Importer 2014-01-28 12:47:20 PST 
<rdar://problem/15928241>
Comment 2 Tim Horton 2014-05-12 16:48:53 PDT 
*** Bug 132844 has been marked as a duplicate of this bug. ***
Comment 3 Tim Horton 2014-05-12 18:10:38 PDT 
Created attachment 231351 [details]
patch
Comment 4 WebKit Commit Bot 2014-05-12 18:12:32 PDT 
Attachment 231351 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:233:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2014-05-12 22:12:29 PDT 
Created attachment 231361 [details]
fix the iOS build
Comment 6 WebKit Commit Bot 2014-05-12 22:13:35 PDT 
Attachment 231361 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:233:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Anders Carlsson 2014-05-13 11:03:18 PDT 
Comment on attachment 231361 [details]
fix the iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=231361&action=review

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:247
> +void ViewSnapshotStore::reduceSnapshotMemoryCost(String uuid)

const String& uuid.

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:271
> +void ViewSnapshotStore::didCompressSnapshot(String uuid, RetainPtr<CGImageRef> newImage, size_t newImageSize)

const String& uuid.
Comment 8 Tim Horton 2014-05-13 11:15:46 PDT 
http://trac.webkit.org/changeset/168689
Comment 9 Tim Horton 2014-05-13 14:28:16 PDT 
Build fix in http://trac.webkit.org/changeset/168739
Comment 10 Tim Horton 2014-05-13 14:36:28 PDT 
And http://trac.webkit.org/changeset/168740 for the sim.