Bug 127784 – WebKit Bot Watcher's Dashboard: Add support for using HTTP authentication with Buildbot

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

Implement support for querying a Buildbot that requires HTTP authentication.

[Daniel Bates]

Created attachment 222461 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 222461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222461&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:44
> +        if (this.status && this.status !== 200 && options.hasOwnProperty("callbackOnLoadError") && options.callbackOnLoadError === true) {
> +            callback({error: this.statusText, errorHTTPCode: this.status});
> +            return;
> +        }

I think that we should always notify the caller of errors. This is actually needed in other code paths too, as we could implement some optimizations if we could track whether iteration data is currently loading, or the load already failed.

An additional callback argument would work. Alternatively, we could pass an object with multiple optional callback functions, e.g. JSON.load(url, { onsuccess = function(data) {...}, onparseerror=..., onloaderror=... }).

[Daniel Bates]

Created attachment 222588 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 222588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222588&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:65
> +    get needsAuthentication()
> +    {
> +        return this.buildbot.needsAuthentication;
> +    },

I'd just put this check inline - we don't need to create a concept of a queue that needs authentication, it's the server that does.

[Daniel Bates]

(In reply to comment #2)
> (From update of attachment 222461 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222461&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:44
> > +        if (this.status && this.status !== 200 && options.hasOwnProperty("callbackOnLoadError") && options.callbackOnLoadError === true) {
> > +            callback({error: this.statusText, errorHTTPCode: this.status});
> > +            return;
> > +        }
> 
> I think that we should always notify the caller of errors. This is actually needed in other code paths too, as we could implement some optimizations if we could track whether iteration data is currently loading, or the load already failed.
> 
> An additional callback argument would work. Alternatively, we could pass an object with multiple optional callback functions, e.g. JSON.load(url, { onsuccess = function(data) {...}, onparseerror=..., onloaderror=... }).

I chose to separate into different bugs the change to teach JSON.load() to optionally send an XMLHTTPRequest with credentials from the change to avoid excessive HTTP authentication prompts. This bug is for the former and bug #127849 is for the latter, which includes adding support for a failure callback function to JSON.load().

[Daniel Bates]

(In reply to comment #4)
> (From update of attachment 222588 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222588&action=review
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:65
> > +    get needsAuthentication()
> > +    {
> > +        return this.buildbot.needsAuthentication;
> > +    },
> 
> I'd just put this check inline - we don't need to create a concept of a queue that needs authentication, it's the server that does.

Will inline before landing.

[Daniel Bates]

Committed r163034: <http://trac.webkit.org/changeset/163034>

[Daniel Bates]

Fixed syntax issue when using JSONP requests and committed the fix in <http://trac.webkit.org/changeset/163040>.