RESOLVED FIXED 127779
Subpixel rendering: Make RoundedRect layout unit aware. 
https://bugs.webkit.org/show_bug.cgi?id=127779
Summary Subpixel rendering: Make RoundedRect layout unit aware.
zalan
Reported 2014-01-28 08:17:14 PST
to be able to paint hairline borders.
Attachments
Patch (40.61 KB, patch)
2014-01-28 08:40 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (44.23 KB, patch)
2014-01-28 12:08 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (47.19 KB, patch)
2014-01-28 13:51 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (47.07 KB, patch)
2014-01-28 19:21 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (47.16 KB, patch)
2014-01-30 20:03 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-01-28 08:40:46 PST
Created attachment 222445 [details] Patch
zalan
Comment 2 2014-01-28 08:41:41 PST
Alternatively, we could use FloatRoundedRect instead of LayouUnit based RoundedRect.
WebKit Commit Bot
Comment 3 2014-01-28 08:42:18 PST
Attachment 222445 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Radar WebKit Bug Importer
Comment 4 2014-01-28 10:01:49 PST
<rdar://problem/15926087>
Simon Fraser (smfr)
Comment 5 2014-01-28 10:25:38 PST
Pls fix the red.
zalan
Comment 6 2014-01-28 12:08:43 PST
Created attachment 222472 [details] Patch
WebKit Commit Bot
Comment 7 2014-01-28 12:10:53 PST
Attachment 222472 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 8 2014-01-28 12:13:09 PST
(In reply to comment #7) > Attachment 222472 [details] did not pass style-queue: > > > ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] > ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] > Total errors found: 2 in 11 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. The style checker gets confused and reports whitespace/indent issue on this, while it actually fails on the following line: (will file a bug against webkit-check-style) RenderBoxModelObject::clipBorderSidePolygon() -> secondQuad[1] = side == BSTop || side == BSBottom ? FloatPoint(quad[0].x(), quad[1].y()) : FloatPoint(quad[1].x(), quad[0].y());
zalan
Comment 9 2014-01-28 13:51:32 PST
Created attachment 222482 [details] Patch
zalan
Comment 10 2014-01-28 13:51:56 PST
Comment on attachment 222482 [details] Patch ews first.
zalan
Comment 11 2014-01-28 19:21:34 PST
Created attachment 222546 [details] Patch
zalan
Comment 12 2014-01-28 19:22:33 PST
Comment on attachment 222546 [details] Patch EWS (failed mac-wk2 before)
zalan
Comment 13 2014-01-30 20:03:39 PST
Created attachment 222786 [details] Patch
zalan
Comment 14 2014-01-30 20:04:26 PST
Comment on attachment 222786 [details] Patch EWS testing the other platform bots.
WebKit Commit Bot
Comment 15 2014-01-30 21:37:06 PST
Comment on attachment 222786 [details] Patch Clearing flags on attachment: 222786 Committed r163156: <http://trac.webkit.org/changeset/163156>
WebKit Commit Bot
Comment 16 2014-01-30 21:37:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.