Bug 127779 - Subpixel rendering: Make RoundedRect layout unit aware.
Summary: Subpixel rendering: Make RoundedRect layout unit aware.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 127524
  Show dependency treegraph
 
Reported: 2014-01-28 08:17 PST by zalan
Modified: 2014-01-30 21:37 PST (History)
8 users (show)

See Also:


Attachments
Patch (40.61 KB, patch)
2014-01-28 08:40 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (44.23 KB, patch)
2014-01-28 12:08 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (47.19 KB, patch)
2014-01-28 13:51 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (47.07 KB, patch)
2014-01-28 19:21 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (47.16 KB, patch)
2014-01-30 20:03 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-01-28 08:17:14 PST
to be able to paint hairline borders.
Comment 1 zalan 2014-01-28 08:40:46 PST
Created attachment 222445 [details]
Patch
Comment 2 zalan 2014-01-28 08:41:41 PST
Alternatively, we could use FloatRoundedRect instead of LayouUnit based RoundedRect.
Comment 3 WebKit Commit Bot 2014-01-28 08:42:18 PST
Attachment 222445 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Radar WebKit Bug Importer 2014-01-28 10:01:49 PST
<rdar://problem/15926087>
Comment 5 Simon Fraser (smfr) 2014-01-28 10:25:38 PST
Pls fix the red.
Comment 6 zalan 2014-01-28 12:08:43 PST
Created attachment 222472 [details]
Patch
Comment 7 WebKit Commit Bot 2014-01-28 12:10:53 PST
Attachment 222472 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 zalan 2014-01-28 12:13:09 PST
(In reply to comment #7)
> Attachment 222472 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
> ERROR: Source/WebCore/rendering/RenderBoxModelObject.cpp:2250:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
> Total errors found: 2 in 11 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

The style checker gets confused and reports whitespace/indent issue on this, while it actually fails on the following line: (will file a bug against webkit-check-style)

RenderBoxModelObject::clipBorderSidePolygon()

-> secondQuad[1] = side == BSTop || side == BSBottom ? FloatPoint(quad[0].x(), quad[1].y())
    : FloatPoint(quad[1].x(), quad[0].y());
Comment 9 zalan 2014-01-28 13:51:32 PST
Created attachment 222482 [details]
Patch
Comment 10 zalan 2014-01-28 13:51:56 PST
Comment on attachment 222482 [details]
Patch

ews first.
Comment 11 zalan 2014-01-28 19:21:34 PST
Created attachment 222546 [details]
Patch
Comment 12 zalan 2014-01-28 19:22:33 PST
Comment on attachment 222546 [details]
Patch

EWS (failed mac-wk2 before)
Comment 13 zalan 2014-01-30 20:03:39 PST
Created attachment 222786 [details]
Patch
Comment 14 zalan 2014-01-30 20:04:26 PST
Comment on attachment 222786 [details]
Patch

EWS testing the other platform bots.
Comment 15 WebKit Commit Bot 2014-01-30 21:37:06 PST
Comment on attachment 222786 [details]
Patch

Clearing flags on attachment: 222786

Committed r163156: <http://trac.webkit.org/changeset/163156>
Comment 16 WebKit Commit Bot 2014-01-30 21:37:09 PST
All reviewed patches have been landed.  Closing bug.