I applied the patch from https://bugs.webkit.org/show_bug.cgi?id=127763 and GTK and EFL builds needs to be fixed.
Created attachment 222434 [details] Patch
Created attachment 222436 [details] patch for EWS, integrated to the original patch
(In reply to comment #1) > Created an attachment (id=222434) [details] > Patch Of course it doesn't build now, because the original patch is not landed yet.
Attachment 222436 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITCode.h:221: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.h:244: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/DFGExitProfile.h:58: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/Repatch.cpp:1497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:7: "JavaScriptCore/ScriptBreakpoint.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/jit/JITOperations.cpp:704: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:165: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:169: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1423: llint_throw_stack_overflow_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1433: llint_stack_check_at_vm_entry is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/jit/ArityCheckFailReturnThunks.cpp:62: Declaration has space between type name and * in m_nextSize * 2 [whitespace/declaration] [3] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:654: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:655: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:44: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:45: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:181: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:191: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:7: "JavaScriptCore/RegularExpression.h" already included at Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:7: "JavaScriptCore/ScriptDebugListener.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:3 [build/include] [4] ERROR: Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:7: "JavaScriptCore/ContentSearchUtilities.h" already included at Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/dfg/DFGOSRExitBase.h:70: The parameter name "jitType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:130: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:131: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:126: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:356: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:362: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:376: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:378: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:498: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 52 in 293 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 222439 [details] patch for EWS, integrated to the original patch with one more fix
Attachment 222439 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITCode.h:221: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.h:244: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/DFGExitProfile.h:58: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/Repatch.cpp:1497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:7: "JavaScriptCore/ScriptBreakpoint.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/jit/JITOperations.cpp:704: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:165: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:169: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1423: llint_throw_stack_overflow_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1433: llint_stack_check_at_vm_entry is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/jit/ArityCheckFailReturnThunks.cpp:62: Declaration has space between type name and * in m_nextSize * 2 [whitespace/declaration] [3] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:654: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:655: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:44: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:45: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:181: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:191: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:7: "JavaScriptCore/RegularExpression.h" already included at Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:7: "JavaScriptCore/ScriptDebugListener.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:3 [build/include] [4] ERROR: Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:7: "JavaScriptCore/ContentSearchUtilities.h" already included at Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/dfg/DFGOSRExitBase.h:70: The parameter name "jitType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:130: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:131: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:126: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:356: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:362: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:376: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:378: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:498: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 52 in 293 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 222439 [details] patch for EWS, integrated to the original patch with one more fix Attachment 222439 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4652300589072384 New failing tests: js/large-expressions.html
Created attachment 222448 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 222439 [details] patch for EWS, integrated to the original patch with one more fix Attachment 222439 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4607192426610688 New failing tests: js/large-expressions.html
Created attachment 222458 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 222439 [details] patch for EWS, integrated to the original patch with one more fix Attachment 222439 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4553432388075520 New failing tests: js/large-expressions.html
Created attachment 222462 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
We can close it since this fix was already integrated to the original patch in https://bugs.webkit.org/show_bug.cgi?id=127763 .
Comment on attachment 222434 [details] Patch Seems fine, but EWS says this didn’t fix the build yet.