127773 – Add new files to the EFL and GTK build systems for the jsCStack branch merge

RESOLVED FIXED 127773

Add new files to the EFL and GTK build systems for the jsCStack branch merge

https://bugs.webkit.org/show_bug.cgi?id=127773

Summary Add new files to the EFL and GTK build systems for the jsCStack branch merge

Csaba Osztrogonác

Reported 2014-01-28 06:12:54 PST

I applied the patch from https://bugs.webkit.org/show_bug.cgi?id=127763 and GTK and EFL builds needs to be fixed.

Attachments
Patch (2.73 KB, patch) 2014-01-28 06:14 PST, Csaba Osztrogonác	darin: review+	Details Formatted Diff Diff
patch for EWS, integrated to the original patch (1.58 MB, patch) 2014-01-28 06:22 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
patch for EWS, integrated to the original patch with one more fix (1.54 MB, patch) 2014-01-28 06:45 PST, Csaba Osztrogonác	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (484.20 KB, application/zip) 2014-01-28 08:45 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (450.98 KB, application/zip) 2014-01-28 09:14 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (483.76 KB, application/zip) 2014-01-28 09:54 PST, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2014-01-28 06:14:13 PST

Created attachment 222434 [details] Patch

Csaba Osztrogonác

Comment 2 2014-01-28 06:22:39 PST

Created attachment 222436 [details] patch for EWS, integrated to the original patch

Csaba Osztrogonác

Comment 3 2014-01-28 06:23:31 PST

(In reply to comment #1) > Created an attachment (id=222434) [details] > Patch Of course it doesn't build now, because the original patch is not landed yet.

WebKit Commit Bot

Comment 4 2014-01-28 06:24:52 PST

Attachment 222436 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITCode.h:221: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.h:244: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/DFGExitProfile.h:58: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/Repatch.cpp:1497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:7: "JavaScriptCore/ScriptBreakpoint.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/jit/JITOperations.cpp:704: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:165: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:169: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1423: llint_throw_stack_overflow_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1433: llint_stack_check_at_vm_entry is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/jit/ArityCheckFailReturnThunks.cpp:62: Declaration has space between type name and * in m_nextSize * 2 [whitespace/declaration] [3] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:654: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:655: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:44: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:45: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:181: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:191: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:7: "JavaScriptCore/RegularExpression.h" already included at Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:7: "JavaScriptCore/ScriptDebugListener.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:3 [build/include] [4] ERROR: Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:7: "JavaScriptCore/ContentSearchUtilities.h" already included at Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/dfg/DFGOSRExitBase.h:70: The parameter name "jitType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:130: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:131: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:126: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:356: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:362: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:376: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:378: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:498: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 52 in 293 files If any of these errors are false positives, please file a bug against check-webkit-style.

Csaba Osztrogonác

Comment 5 2014-01-28 06:45:14 PST

Created attachment 222439 [details] patch for EWS, integrated to the original patch with one more fix

WebKit Commit Bot

Comment 6 2014-01-28 06:49:16 PST

Attachment 222439 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JITCode.h:221: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.h:244: The parameter name "ref" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/DFGExitProfile.h:58: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/Repatch.cpp:1497: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:315: Wrong number of spaces before statement. (expected: 9) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:312: The parameter name "codeBlock" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:7: "JavaScriptCore/ScriptBreakpoint.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptBreakpoint.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/jit/JITOperations.cpp:704: One line control clauses should not use braces. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/runtime/VM.h:71: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:165: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:169: Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/PutByIdStatus.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:38: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:159: __rcf_exec is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1423: llint_throw_stack_overflow_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1433: llint_stack_check_at_vm_entry is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:34: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/profiler/ProfilerCompilationKind.h:35: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] ERROR: Source/JavaScriptCore/jit/ArityCheckFailReturnThunks.cpp:62: Declaration has space between type name and * in m_nextSize * 2 [whitespace/declaration] [3] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:654: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/interpreter/Interpreter.cpp:655: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:44: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.h:45: The parameter name "gpr" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:181: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLAbstractHeap.cpp:191: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:7: "JavaScriptCore/RegularExpression.h" already included at Source/WebCore/ForwardingHeaders/yarr/RegularExpression.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:62: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/ftl/FTLSlowPathCall.h:66: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:7: "JavaScriptCore/ScriptDebugListener.h" already included at Source/WebCore/ForwardingHeaders/inspector/ScriptDebugListener.h:3 [build/include] [4] ERROR: Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:7: "JavaScriptCore/ContentSearchUtilities.h" already included at Source/WebCore/ForwardingHeaders/inspector/ContentSearchUtilities.h:3 [build/include] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:116: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:120: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:123: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLUnwindInfo.cpp:31: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/JavaScriptCore/dfg/DFGOSRExitBase.h:70: The parameter name "jitType" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:130: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITCode.cpp:131: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/heap/MachineStackMarker.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:126: More than one command on the same line [whitespace/newline] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.cpp:134: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.h:578: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:129: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:59: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:100: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/jit/JITInlineCacheGenerator.h:113: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:356: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:362: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:376: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:378: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/JavaScriptCore/llint/LowLevelInterpreter.cpp:498: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 52 in 293 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 7 2014-01-28 08:45:51 PST

Comment on attachment 222439 [details] patch for EWS, integrated to the original patch with one more fix Attachment 222439 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4652300589072384 New failing tests: js/large-expressions.html

Build Bot

Comment 8 2014-01-28 08:45:53 PST

Created attachment 222448 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2014-01-28 09:14:11 PST

Comment on attachment 222439 [details] patch for EWS, integrated to the original patch with one more fix Attachment 222439 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4607192426610688 New failing tests: js/large-expressions.html

Build Bot

Comment 10 2014-01-28 09:14:15 PST

Created attachment 222458 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 11 2014-01-28 09:54:05 PST

Comment on attachment 222439 [details] patch for EWS, integrated to the original patch with one more fix Attachment 222439 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4553432388075520 New failing tests: js/large-expressions.html

Build Bot

Comment 12 2014-01-28 09:54:08 PST

Created attachment 222462 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Csaba Osztrogonác

Comment 13 2014-01-28 09:57:05 PST

We can close it since this fix was already integrated to the original patch in https://bugs.webkit.org/show_bug.cgi?id=127763 .

Darin Adler

Comment 14 2014-01-28 10:01:05 PST

Comment on attachment 222434 [details] Patch Seems fine, but EWS says this didn’t fix the build yet.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P1

Severity Blocker

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component JavaScriptCore

Assignee

Csaba Osztrogonác

Reported

2014-01-28 06:12 PST

Modified

2014-01-28 10:01 PST History

CC List

11 users Show

URL

Keywords

Depends on

Blocks

127763

Dependencies

tree graph