WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 127717
IDB: Rename "IDBTransactionIdentifier" to be more general purpose
https://bugs.webkit.org/show_bug.cgi?id=127717
Summary
IDB: Rename "IDBTransactionIdentifier" to be more general purpose
Brady Eidson
Reported
2014-01-27 15:38:08 PST
IDB: Rename "IDBTransactionIdentifier" to be more general purpose The purpose of IDBTransactionIdentifier is to pair a DatabaseProcessIDBConnection with an integer ID for unique hashing. Previously we only cared about transaction integer IDs but now we'll need to use for cursor integer IDs also. My proposed rename is to "IDBIdentifier"
Attachments
Patch v1
(72.89 KB, patch)
2014-01-27 15:40 PST
,
Brady Eidson
thorton
: review+
Details
Formatted Diff
Diff
Patch take 2 (v1)
(54.68 KB, patch)
2014-01-27 16:00 PST
,
Brady Eidson
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2014-01-27 15:40:43 PST
Created
attachment 222371
[details]
Patch v1
Brady Eidson
Comment 2
2014-01-27 15:44:28 PST
http://trac.webkit.org/changeset/162877
Brady Eidson
Comment 3
2014-01-27 15:54:40 PST
This was incomplete. Since the type name no longer carries all the information, variable names will need to be updated as well.
Brady Eidson
Comment 4
2014-01-27 16:00:44 PST
Created
attachment 222376
[details]
Patch take 2 (v1)
Brady Eidson
Comment 5
2014-01-27 17:13:40 PST
Followup landed in
http://trac.webkit.org/changeset/162891
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug