Bug 127717 - IDB: Rename "IDBTransactionIdentifier" to be more general purpose
Summary: IDB: Rename "IDBTransactionIdentifier" to be more general purpose
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 124521
  Show dependency tree / graph
 
Reported: 2014-01-27 15:38 PST by Brady Eidson
Modified: 2014-01-27 17:13 PST (History)
0 users

See Also:

Attachments
Patch v1 (72.89 KB, patch)
2014-01-27 15:40 PST, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
Patch take 2 (v1) (54.68 KB, patch)
2014-01-27 16:00 PST, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-01-27 15:38:08 PST 
IDB: Rename "IDBTransactionIdentifier" to be more general purpose

The purpose of IDBTransactionIdentifier is to pair a DatabaseProcessIDBConnection with an integer ID for unique hashing.

Previously we only cared about transaction integer IDs but now we'll need to use for cursor integer IDs also.

My proposed rename is to "IDBIdentifier"
Comment 1 Brady Eidson 2014-01-27 15:40:43 PST 
Created attachment 222371 [details]
Patch v1
Comment 2 Brady Eidson 2014-01-27 15:44:28 PST 
http://trac.webkit.org/changeset/162877
Comment 3 Brady Eidson 2014-01-27 15:54:40 PST 
This was incomplete.  Since the type name no longer carries all the information, variable names will need to be updated as well.
Comment 4 Brady Eidson 2014-01-27 16:00:44 PST 
Created attachment 222376 [details]
Patch take 2 (v1)
Comment 5 Brady Eidson 2014-01-27 17:13:40 PST 
Followup landed in http://trac.webkit.org/changeset/162891