Bug 127715 - [New Multicolumn] Add support for block progression axis and reverse direction
Summary: [New Multicolumn] Add support for block progression axis and reverse direction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-27 15:22 PST by Dave Hyatt
Modified: 2014-01-27 17:22 PST (History)
4 users (show)

See Also:

Attachments
Patch (44.35 KB, patch)
2014-01-27 15:29 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (44.32 KB, patch)
2014-01-27 15:51 PST, Dave Hyatt 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-01-27 15:22:00 PST 
These are used for fancy pagination modes.
Comment 1 Dave Hyatt 2014-01-27 15:29:50 PST 
Created attachment 222368 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-27 15:31:33 PST 
Attachment 222368 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:438:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:472:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:473:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderMultiColumnSet.cpp:474:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:776:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2014-01-27 15:51:06 PST 
Created attachment 222375 [details]
Patch
Comment 4 Dave Hyatt 2014-01-27 17:22:10 PST 
Fixed in r162892.