Bug 127713 - js/dom/post-message-numeric-property.html is flaky
Summary: js/dom/post-message-numeric-property.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-27 14:44 PST by Alexey Proskuryakov
Modified: 2014-01-28 14:21 PST (History)
3 users (show)

See Also:

Attachments
proposed fix (10.55 KB, patch)
2014-01-28 13:46 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-27 14:44:21 PST 
js/dom/post-message-numeric-property.html has recently started to frequently fail on Mac:

----------
@@ -3,8 +3,8 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+PASS e.data[0] is 'hi'
 PASS successfullyParsed is true
 
 TEST COMPLETE
-PASS e.data[0] is 'hi'
 ----------
Comment 1 Alexey Proskuryakov 2014-01-27 14:48:01 PST 
The test is inherently flaky, because it mixes up testRunner and js-test-post.js approaches to being asynchronous. That just doesn't work.

Not sure why this only started to fail recently.
Comment 2 Alexey Proskuryakov 2014-01-28 13:46:30 PST 
Created attachment 222481 [details]
proposed fix
Comment 3 Geoffrey Garen 2014-01-28 13:49:32 PST 
Comment on attachment 222481 [details]
proposed fix

r=me
Comment 4 WebKit Commit Bot 2014-01-28 14:21:05 PST 
Comment on attachment 222481 [details]
proposed fix

Clearing flags on attachment: 222481

Committed r162961: <http://trac.webkit.org/changeset/162961>
Comment 5 WebKit Commit Bot 2014-01-28 14:21:07 PST 
All reviewed patches have been landed.  Closing bug.