Bug 127708 - IDB: LevelDB backing store shouldn't know about IDBCursor or IDBCallbacks
Summary: IDB: LevelDB backing store shouldn't know about IDBCursor or IDBCallbacks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 124521
  Show dependency tree / graph
 
Reported: 2014-01-27 14:21 PST by Brady Eidson
Modified: 2014-01-27 14:34 PST (History)
3 users (show)

See Also:

Attachments
Patch v1 (15.56 KB, patch)
2014-01-27 14:31 PST, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-01-27 14:21:55 PST 
IDB: LevelDB backing store shouldn't know about IDBCursor or IDBCallbacks

Move that knowledge to the IDBCursorBackendOperations
Comment 1 Brady Eidson 2014-01-27 14:31:10 PST 
Created attachment 222361 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-01-27 14:32:49 PST 
Attachment 222361 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:43:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBCursorBackendOperations.cpp:66:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2014-01-27 14:34:19 PST 
http://trac.webkit.org/changeset/162869