Bug 127702 - [iOS] preload=none prevents play()
Summary: [iOS] preload=none prevents play()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-27 13:24 PST by Eric Carlson
Modified: 2014-01-27 14:43 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (2.54 KB, patch)
2014-01-27 14:28 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-01-27 13:24:24 PST 
play() does not work when preload=none and not using the media player proxy.
Comment 1 Eric Carlson 2014-01-27 14:28:17 PST 
Created attachment 222358 [details]
Proposed patch
Comment 2 Jer Noble 2014-01-27 14:33:40 PST 
Comment on attachment 222358 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222358&action=review

r=me, with nit:

> Source/WebCore/html/HTMLMediaElement.cpp:4257
>  #if PLATFORM(IOS)
> -    if (shouldBePlaying && !m_requestingPlay && !m_player->readyForPlayback())
> -        shouldBePlaying = false;
> -    else if (!shouldBePlaying && m_requestingPlay && m_player->readyForPlayback())
> -        shouldBePlaying = true;
> +    if (shouldUseVideoPluginProxy()) {
> +        if (shouldBePlaying && !m_requestingPlay && !m_player->readyForPlayback())
> +            shouldBePlaying = false;
> +        else if (!shouldBePlaying && m_requestingPlay && m_player->readyForPlayback())
> +            shouldBePlaying = true;
> +    }
>  #endif

Could this #if PLATFORM(IOS) be replaced by #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)?
Comment 3 Eric Carlson 2014-01-27 14:43:32 PST 
Committed r162870: https://trac.webkit.org/r162870