RESOLVED FIXED 127702
[iOS] preload=none prevents play() 
https://bugs.webkit.org/show_bug.cgi?id=127702
Summary [iOS] preload=none prevents play()
Eric Carlson
Reported 2014-01-27 13:24:24 PST
play() does not work when preload=none and not using the media player proxy.
Attachments
Proposed patch (2.54 KB, patch)
2014-01-27 14:28 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-01-27 14:28:17 PST
Created attachment 222358 [details] Proposed patch
Jer Noble
Comment 2 2014-01-27 14:33:40 PST
Comment on attachment 222358 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=222358&action=review r=me, with nit: > Source/WebCore/html/HTMLMediaElement.cpp:4257 > #if PLATFORM(IOS) > - if (shouldBePlaying && !m_requestingPlay && !m_player->readyForPlayback()) > - shouldBePlaying = false; > - else if (!shouldBePlaying && m_requestingPlay && m_player->readyForPlayback()) > - shouldBePlaying = true; > + if (shouldUseVideoPluginProxy()) { > + if (shouldBePlaying && !m_requestingPlay && !m_player->readyForPlayback()) > + shouldBePlaying = false; > + else if (!shouldBePlaying && m_requestingPlay && m_player->readyForPlayback()) > + shouldBePlaying = true; > + } > #endif Could this #if PLATFORM(IOS) be replaced by #if ENABLE(PLUGIN_PROXY_FOR_VIDEO)?
Eric Carlson
Comment 3 2014-01-27 14:43:32 PST
Committed r162870: https://trac.webkit.org/r162870
Note You need to log in before you can comment on or make changes to this bug.