Bug 127701 - [iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
Summary: [iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
: 127758 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-27 13:21 PST by Jer Noble
Modified: 2014-01-30 11:00 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.79 KB, patch)
2014-01-27 13:49 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (6.06 KB, patch)
2014-01-27 13:52 PST, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff
Patch (8.39 KB, patch)
2014-01-27 14:06 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-01-27 13:21:22 PST
[iOS] Use callOnMainThread() not dispatch_async() in MediaPlayerPrivateAVFoundationObjC
Comment 1 Jer Noble 2014-01-27 13:49:04 PST
Created attachment 222351 [details]
Patch
Comment 2 Jer Noble 2014-01-27 13:52:11 PST
Created attachment 222352 [details]
Patch
Comment 3 Eric Carlson 2014-01-27 14:01:52 PST
Comment on attachment 222352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222352&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2124
> +        if (strongSelf->m_callback)
> +            strongSelf->m_callback->didCancelLoadingRequest(strongRequest.get());

Why do you use "strongSelf->m_callback" here, but just "m_callback" everywhere else?
Comment 4 Jer Noble 2014-01-27 14:06:32 PST
Created attachment 222355 [details]
Patch

Now with more weakPtr.
Comment 5 WebKit Commit Bot 2014-01-27 15:46:45 PST
Comment on attachment 222355 [details]
Patch

Clearing flags on attachment: 222355

Committed r162879: <http://trac.webkit.org/changeset/162879>
Comment 6 Jer Noble 2014-01-28 10:21:30 PST
*** Bug 127758 has been marked as a duplicate of this bug. ***