Bug 127685 - WebCrypto keyUsage is no longer an optional argument
Summary: WebCrypto keyUsage is no longer an optional argument
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Éva Balázsfalvi
Keywords: InRadar
Depends on:
Blocks: 160883
  Show dependency treegraph
Reported: 2014-01-27 09:21 PST by Alexey Proskuryakov
Modified: 2016-12-01 14:55 PST (History)
5 users (show)

See Also:

Patch (2.49 KB, patch)
2014-11-03 06:55 PST, Éva Balázsfalvi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-27 09:21:51 PST
See <https://www.w3.org/Bugs/Public/show_bug.cgi?id=19416>, it doesn't make sense for keyUsage to have the default empty value.
Comment 1 Alexey Proskuryakov 2014-02-20 17:52:46 PST
https://www.w3.org/Bugs/Public/show_bug.cgi?id=19705 is the correct bug.
Comment 2 Éva Balázsfalvi 2014-11-03 06:55:09 PST
Created attachment 240848 [details]
Comment 3 Alexey Proskuryakov 2014-11-03 09:22:34 PST
Comment on attachment 240848 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=240848&action=review

This patch does not change behavior - everything besides the function name is essentially a comment for [Custom] properties. The actual implementation that makes these optional is in JSSubtleCryptoCustom.cpp.

It is probably OK to make this particular change. But I think that the better approach would be to freeze the existing implementation under crypto.webkitSubtle, and start one that matches the new spec and is exposed as crypto.subtle. There were incompatible changes that we shouldn't be making for webkitSubtle. And generally, the spec changed so much that a clean reimplementation is probably easier than massaging the existing one.

> Source/WebCore/ChangeLog:8
> +        No new tests, no behavior change.

There is indeed no behavior change (see above), however making arguments non-optional is definitely a behavior change that needs to be tested.
Comment 4 Radar WebKit Bug Importer 2016-08-15 18:09:42 PDT