Bug 127678 - Buildfix for !ENABLE(COMPARE_AND_SWAP) platforms after r162774
Summary: Buildfix for !ENABLE(COMPARE_AND_SWAP) platforms after r162774
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-27 01:59 PST by Csaba Osztrogonác
Modified: 2014-01-27 03:08 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.03 KB, patch)
2014-01-27 02:02 PST, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-01-27 01:59:42 PST
After http://trac.webkit.org/changeset/162774 we should use std::mutex and std::atomic 
instead of WTF threading primitives. This change broke !ENABLE(COMPARE_AND_SWAP) builds,
for example the ARM traditional build:

/home/webkitbuildbot/slaves/efl-ARMv7-traditional-build/buildslave/efl-armv7-traditional-build/build/Source/WebCore/platform/text/TextBreakIterator.cpp: In function 'bool WebCore::compareAndSwapNonSharedCharacterBreakIterator(WebCore::TextBreakIterator*, WebCore::TextBreakIterator*)':
/home/webkitbuildbot/slaves/efl-ARMv7-traditional-build/buildslave/efl-armv7-traditional-build/build/Source/WebCore/platform/text/TextBreakIterator.cpp:279:12: error: 'Mutex' does not name a type
/home/webkitbuildbot/slaves/efl-ARMv7-traditional-build/buildslave/efl-armv7-traditional-build/build/Source/WebCore/platform/text/TextBreakIterator.cpp:280:5: error: 'MutexLocker' was not declared in this scope
/home/webkitbuildbot/slaves/efl-ARMv7-traditional-build/buildslave/efl-armv7-traditional-build/build/Source/WebCore/platform/text/TextBreakIterator.cpp:280:17: error: expected ';' before 'locker'
Comment 1 Csaba Osztrogonác 2014-01-27 02:02:34 PST
Created attachment 222312 [details]
Patch
Comment 2 Zoltan Herczeg 2014-01-27 02:40:31 PST
Comment on attachment 222312 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2014-01-27 03:08:46 PST
Comment on attachment 222312 [details]
Patch

Clearing flags on attachment: 222312

Committed r162833: <http://trac.webkit.org/changeset/162833>
Comment 4 WebKit Commit Bot 2014-01-27 03:08:49 PST
All reviewed patches have been landed.  Closing bug.