Bug 127671 - WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
Summary: WebCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-26 22:18 PST by Joseph Pecoraro
Modified: 2014-01-27 20:01 PST (History)
36 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (52.48 KB, patch)
2014-01-26 22:41 PST, Joseph Pecoraro 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-26 22:18:43 PST 
Catches a few subtle bugs, identified some possible bugs, but overall mostly straightforward.
Comment 1 Joseph Pecoraro 2014-01-26 22:41:36 PST 
Created attachment 222303 [details]
[PATCH] Proposed Fix

Probably relies on the JavaScriptCore patch landing as well so I won't put cq? on it. Tested debug and release compiles.
Comment 2 Ryosuke Niwa 2014-01-27 19:09:20 PST 
Comment on attachment 222303 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=222303&action=review

> Source/WebCore/css/SVGCSSParser.cpp:274
> +        break;

Nice catch!

> Source/WebCore/css/StyleResolver.cpp:2230
> +            return;
>          }
> +        

Ditto!

> Source/WebCore/rendering/AutoTableLayout.cpp:-523
> -            // fall through

Huh, out-dated comment. That's classic.
Comment 3 Joseph Pecoraro 2014-01-27 20:01:31 PST 
Landed <http://trac.webkit.org/changeset/162907>.