Bug 127668 - Rename CachedImage::isImage() to isCachedImage() and add toCachedImage()
Summary: Rename CachedImage::isImage() to isCachedImage() and add toCachedImage()
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-26 19:26 PST by David Kilzer (:ddkilzer)
Modified: 2014-02-13 03:51 PST (History)
8 users (show)

See Also:

Attachments
Patch v1 (12.01 KB, patch)
2014-01-26 20:12 PST, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2014-01-26 19:26:01 PST 
Rename CachedImage::isImage() to isCachedImage() and add toCachedImage() for type safety checking.

See Bug 126761 Comment #13.
Comment 1 David Kilzer (:ddkilzer) 2014-01-26 20:12:28 PST 
Created attachment 222297 [details]
Patch v1
Comment 2 Darin Adler 2014-01-27 10:51:38 PST 
Comment on attachment 222297 [details]
Patch v1

I know you got concerned about this because of RenderObject::isImage not meaning the RenderObject is a RenderImage, but I don’t see the analogy here. This new names don’t seem to be an improvement here.
Comment 3 David Kilzer (:ddkilzer) 2014-01-27 13:52:14 PST 
(In reply to comment #2)
> (From update of attachment 222297 [details])
> I know you got concerned about this because of RenderObject::isImage not meaning the RenderObject is a RenderImage, but I don’t see the analogy here. This new names don’t seem to be an improvement here.

Okay.
Comment 4 Csaba Osztrogonác 2014-02-13 03:51:52 PST 
Comment on attachment 222297 [details]
Patch v1

Cleared review? from attachment 222297 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).