Bug 127665 - WebKit2: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
Summary: WebKit2: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-26 17:40 PST by Joseph Pecoraro
Modified: 2014-01-27 20:12 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.03 KB, patch)
2014-01-26 17:44 PST, Joseph Pecoraro 		andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-26 17:40:04 PST 
Looks like this catches some legit bugs. Only a few instances.
Comment 1 Joseph Pecoraro 2014-01-26 17:44:08 PST 
Created attachment 222294 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-01-26 18:45:13 PST 
Comment on attachment 222294 [details]
[PATCH] Proposed Fix

Rejecting attachment 222294 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/DynamicLinkerEnvironmentExtractor.o

** BUILD FAILED **


The following build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/UniqueIDBDatabase.o DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

Full output: http://webkit-queues.appspot.com/results/5370354696454144
Comment 3 Joseph Pecoraro 2014-01-26 19:06:45 PST 
Looks like this needs the JSC patch to land before it can land. I will land manually tomorrow.
Comment 4 Darin Adler 2014-01-27 10:50:31 PST 
Comment on attachment 222294 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=222294&action=review

> Source/WebKit2/Shared/UserData.cpp:157
>      case API::Object::Type::Point:
>          static_cast<const API::Point&>(object).encode(encoder);
> +        break;
>  
>      case API::Object::Type::Rect:
>          static_cast<const API::Rect&>(object).encode(encoder);
> +        break;

Wow, it caught a real bug!
Comment 5 Joseph Pecoraro 2014-01-27 20:12:25 PST 
Landed <http://trac.webkit.org/changeset/162909>