Bug 127664 - WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
Summary: WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where n...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-26 17:31 PST by Joseph Pecoraro
Modified: 2014-01-27 20:12 PST (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.97 KB, patch)
2014-01-26 17:32 PST, Joseph Pecoraro 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-26 17:31:06 PST 
Easy! Only a few instances.
Comment 1 Joseph Pecoraro 2014-01-26 17:32:23 PST 
Created attachment 222293 [details]
[PATCH] Proposed Fix
Comment 2 Darin Adler 2014-01-27 10:49:43 PST 
Comment on attachment 222293 [details]
[PATCH] Proposed Fix

r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about
Comment 3 Joseph Pecoraro 2014-01-27 10:58:05 PST 
(In reply to comment #2)
> (From update of attachment 222293 [details])
> r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about

That was a addressed in the JSC patch that hasn't landed yet.
Comment 4 Joseph Pecoraro 2014-01-27 20:11:53 PST 
Landed <http://trac.webkit.org/changeset/162908>