WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
127664
WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed
https://bugs.webkit.org/show_bug.cgi?id=127664
Summary
WebKit1: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where n...
Joseph Pecoraro
Reported
2014-01-26 17:31:06 PST
Easy! Only a few instances.
Attachments
[PATCH] Proposed Fix
(4.97 KB, patch)
2014-01-26 17:32 PST
,
Joseph Pecoraro
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2014-01-26 17:32:23 PST
Created
attachment 222293
[details]
[PATCH] Proposed Fix
Darin Adler
Comment 2
2014-01-27 10:49:43 PST
Comment on
attachment 222293
[details]
[PATCH] Proposed Fix r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about
Joseph Pecoraro
Comment 3
2014-01-27 10:58:05 PST
(In reply to
comment #2
)
> (From update of
attachment 222293
[details]
) > r=me assuming you deal with the JSObject.h problem that the Mac EWS bot is complaining about
That was a addressed in the JSC patch that hasn't landed yet.
Joseph Pecoraro
Comment 4
2014-01-27 20:11:53 PST
Landed <
http://trac.webkit.org/changeset/162908
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug