Bug 127661 - [New Multicolumn] Change the axis property to be a boolean like other isInline checks
Summary: [New Multicolumn] Change the axis property to be a boolean like other isInlin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-26 15:44 PST by Dave Hyatt
Modified: 2014-01-26 19:52 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.41 KB, patch)
2014-01-26 15:45 PST, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-01-26 15:44:24 PST 
Change the axis property to be a boolean like other isInline checks. This makes it easier to share between the old/new multi-column and matches other uses of isInline/childrenInline() etc. in the engine.
Comment 1 Dave Hyatt 2014-01-26 15:45:09 PST 
Created attachment 222290 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-01-26 15:46:39 PST 
Comment on attachment 222290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222290&action=review

> Source/WebCore/rendering/RenderMultiColumnFlowThread.h:38
> -
> +    

Added whitespace.
Comment 3 Dave Hyatt 2014-01-26 19:52:58 PST 
Landed in r162822.