Bug 127651 - [GTK] Web Inspector doesn't work with network process enabled
Summary: [GTK] Web Inspector doesn't work with network process enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108832
  Show dependency tree / graph
 
Reported: 2014-01-26 07:23 PST by Carlos Garcia Campos
Modified: 2014-02-27 03:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2014-02-27 02:48 PST, Carlos Garcia Campos 		svillar: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-01-26 07:23:06 PST 
Nothing happens when inspecting an element in MiniBrowser and unit tests time out.

../../Tools/Scripts/run-gtk-tests --verbose --no-xvfb Programs/TestWebKitAPI/WebKit2Gtk/TestInspector***
TEST: Programs/TestWebKitAPI/WebKit2Gtk/TestInspector... (pid=7928)
  /webkit2/WebKitWebInspector/default:                                 OK
  /webkit2/WebKitWebInspector/manual-attach-detach:                    OK
  /webkit2/WebKitWebInspector/custom-container-destroyed:              OK
PASS: Programs/TestWebKitAPI/WebKit2Gtk/TestInspector

$ WEBKIT_USE_NETWORK_PROCESS=1 ../../Tools/Scripts/run-gtk-tests --verbose --no-xvfb Programs/TestWebKitAPI/WebKit2Gtk/TestInspector
TEST: Programs/TestWebKitAPI/WebKit2Gtk/TestInspector... (pid=7832)
  /webkit2/WebKitWebInspector/default:                                 OK
TEST: Programs/TestWebKitAPI/WebKit2Gtk/TestInspector: TIMEOUT
Comment 1 Carlos Garcia Campos 2014-01-27 02:24:34 PST 
It doesn't always happen, sometimes it works perfectly so it looks like a race condition somewhere. I've debugged this for a while and I've noticed that when it doesn't work some resources are not loaded, for example InspectorJSBackendCommands.js and InspectorWebBackendCommands.js. Those are inserted in the document by LoadInspectorBackendCommands.js which is always loaded.
Comment 2 Carlos Garcia Campos 2014-02-27 02:48:23 PST 
Created attachment 225351 [details]
Patch
Comment 3 Sergio Villar Senin 2014-02-27 03:15:20 PST 
Comment on attachment 225351 [details]
Patch

Awesome find!
Comment 4 Carlos Garcia Campos 2014-02-27 03:25:06 PST 
Committed r164787: <http://trac.webkit.org/changeset/164787>