Bug 127643 - Remove dead code from the JSC profiler
Summary: Remove dead code from the JSC profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-25 21:40 PST by Timothy Hatcher
Modified: 2014-01-25 22:51 PST (History)
6 users (show)

See Also:

Attachments
Patch (23.37 KB, patch)
2014-01-25 21:44 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-25 21:40:20 PST 
There is dead code in LegacyProfiler and ProfileNode that can be removed. It is there from when UI features like exclude and focus were implemented on the backend.
Comment 1 Timothy Hatcher 2014-01-25 21:44:46 PST 
Created attachment 222252 [details]
Patch
Comment 2 Mark Lam 2014-01-25 21:51:39 PST 
Comment on attachment 222252 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-01-25 22:26:07 PST 
Comment on attachment 222252 [details]
Patch

Clearing flags on attachment: 222252

Committed r162796: <http://trac.webkit.org/changeset/162796>
Comment 4 WebKit Commit Bot 2014-01-25 22:26:09 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Mark Lam 2014-01-25 22:51:08 PST 
There was a dataLog reference to the obsolete “visible” timers that was breaking the debug build.  This has been fixed in r162797: <http://trac.webkit.org/r162797>.