Bug 127632 - Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds
Summary: Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-25 14:43 PST by Sam Weinig
Modified: 2014-01-25 16:31 PST (History)
0 users

See Also:

Attachments
Patch (49.36 KB, patch)
2014-01-25 14:45 PST, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-01-25 14:43:18 PST 
Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds
Comment 1 Sam Weinig 2014-01-25 14:45:56 PST 
Created attachment 222236 [details]
Patch
Comment 2 Darin Adler 2014-01-25 14:48:23 PST 
Comment on attachment 222236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222236&action=review

> Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:37
> +static SQLiteDatabaseTrackerClient* s_staticSQLiteDatabaseTrackerClient = 0;

nullptr (or omit)

> Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:40
> +static Mutex& transactionInProgressMutex()

Can we use C++ standard library locking instead of WTF locking?

> Source/WebCore/platform/sql/SQLiteDatabaseTracker.h:43
> +#if !ASSERT_DISABLED
> +bool hasTransactionInProgress();
> +#endif // !ASSERT_DISABLED

That endif comment. Really?
Comment 3 Sam Weinig 2014-01-25 16:26:30 PST 
(In reply to comment #2)
> (From update of attachment 222236 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222236&action=review
> 
> > Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:37
> > +static SQLiteDatabaseTrackerClient* s_staticSQLiteDatabaseTrackerClient = 0;
> 
> nullptr (or omit)
> 
> > Source/WebCore/platform/sql/SQLiteDatabaseTracker.cpp:40
> > +static Mutex& transactionInProgressMutex()
> 
> Can we use C++ standard library locking instead of WTF locking?
> 
> > Source/WebCore/platform/sql/SQLiteDatabaseTracker.h:43
> > +#if !ASSERT_DISABLED
> > +bool hasTransactionInProgress();
> > +#endif // !ASSERT_DISABLED
> 
> That endif comment. Really?

Heh, I just moved the file, but I will clean it up before landing.
Comment 4 Sam Weinig 2014-01-25 16:31:57 PST 
Committed r162787: <http://trac.webkit.org/changeset/162787>