Bug 127625 - Remove atomicIncrement/atomicDecrement
Summary: Remove atomicIncrement/atomicDecrement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-25 11:54 PST by Anders Carlsson
Modified: 2014-01-25 13:12 PST (History)
7 users (show)

See Also:


Attachments
Patch (19.42 KB, patch)
2014-01-25 11:56 PST, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (19.42 KB, patch)
2014-01-25 12:32 PST, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-25 11:54:02 PST
Remove atomicIncrement/atomicDecrement
Comment 1 Anders Carlsson 2014-01-25 11:56:51 PST
Created attachment 222224 [details]
Patch
Comment 2 Andreas Kling 2014-01-25 12:27:32 PST
Comment on attachment 222224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222224&action=review

> Source/WTF/wtf/ThreadSafeRefCounted.h:97
> -        if (atomicDecrement(&m_refCount) <= 0) {
> +        if (++m_refCount <= 0) {

Bug!
Comment 3 Anders Carlsson 2014-01-25 12:32:58 PST
Created attachment 222226 [details]
Patch
Comment 4 Andreas Kling 2014-01-25 12:39:25 PST
Comment on attachment 222226 [details]
Patch

r=me
Comment 5 Anders Carlsson 2014-01-25 13:12:13 PST
Committed r162777: <http://trac.webkit.org/changeset/162777>