Bug 127623 - Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
Summary: Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
: 126857 (view as bug list)
Depends on: 164473
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-25 10:53 PST by Darin Adler
Modified: 2016-11-07 04:08 PST (History)
2 users (show)

See Also:


Attachments
Patch (34.18 KB, patch)
2014-01-25 10:58 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (34.16 KB, patch)
2014-01-25 11:42 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (34.17 KB, patch)
2014-01-25 11:43 PST, Darin Adler
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-01-25 10:53:47 PST
Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
Comment 1 Darin Adler 2014-01-25 10:58:29 PST
Created attachment 222219 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-25 10:59:54 PST
Attachment 222219 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:28:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2014-01-25 11:42:09 PST
Created attachment 222221 [details]
Patch
Comment 4 Darin Adler 2014-01-25 11:43:09 PST
Created attachment 222222 [details]
Patch
Comment 5 Darin Adler 2014-01-25 13:32:05 PST
Committed r162782: <http://trac.webkit.org/changeset/162782>
Comment 6 Daniel Bates 2014-07-06 14:14:58 PDT
*** Bug 126857 has been marked as a duplicate of this bug. ***