Additional spaces after defining the inset parameters dependent how many parameters have been specified inset(2px) gets to inset(2px ) - three spaces inset(2px 2px) gets to inset(2px 2px 2px ) - two spaces inset(2px 2px 2px) gets to inset(2px 2px 2px ) - one space element style: element.style.webkitShapeInside = "inset(2px)"
Created attachment 222212 [details] Patch
Comment on attachment 222212 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222212&action=review r=me with comments. > Source/WebCore/css/CSSBasicShapes.cpp:428 > + if (!right.isNull()) { > + result.appendLiteral(separator); > + result.append(right); > + if (!bottom.isNull()) { > + result.appendLiteral(separator); > + result.append(bottom); > + if (!left.isNull()) { > + result.appendLiteral(separator); > + result.append(left); > + } > + } > + } I don't think that it needs to be nested... At this point we should be able to rely on sane data, shouldn't we? Of course we would have some extra checks though. I leaf it up to you. > Source/WebCore/css/CSSBasicShapes.cpp:444 > + result.append("/"); s/"/'/g
Created attachment 222334 [details] Patch for landing
Comment on attachment 222334 [details] Patch for landing Clearing flags on attachment: 222334 Committed r162848: <http://trac.webkit.org/changeset/162848>
All reviewed patches have been landed. Closing bug.