Bug 127615 – Web Inspector: Position the completion suggestions popup below if there is room

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Diego Pino]

When filling the value of a CSS property, a completion list with suggestions pops up. Currently the popup is positioned above the edited CSS property is there is more room than below. A FIXME recommends to always position the popup below if there is room enough.

[Radar WebKit Bug Importer]

<rdar://problem/15908842>

[Diego Pino]

Created attachment 222199 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 222199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222199&action=review

Nice! r=me with some style nits.

> Source/WebInspectorUI/ChangeLog:6
> +        Web Inspector: Position the completion suggestions popup below if
> +        there is room enough.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=127615

Style: `./Tools/Scripts/prepare-ChangeLog -b 127615` would not wrap the title line and would put the bugzilla bug on the next line without an empty line between.

> Source/WebInspectorUI/UserInterface/CompletionSuggestionsView.js:153
> +        // Position the suggestions below the anchor. If there is no room, position the suggestions above

Style: Comments in WebKit are full sentences. This second sentence should end in a period.

[Diego Pino]

Created attachment 222237 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 222237 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 222237 [details]
Patch

Clearing flags on attachment: 222237

Committed r162790: <http://trac.webkit.org/changeset/162790>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.