Bug 127615 - Web Inspector: Position the completion suggestions popup below if there is room
Summary: Web Inspector: Position the completion suggestions popup below if there is room
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-25 01:26 PST by Diego Pino
Modified: 2014-01-25 17:03 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2014-01-25 01:30 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (1.91 KB, patch)
2014-01-25 14:49 PST, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2014-01-25 01:26:08 PST 
When filling the value of a CSS property, a completion list with suggestions pops up. Currently the popup is positioned above the edited CSS property is there is more room than below. A FIXME recommends to always position the popup below if there is room enough.
Comment 1 Radar WebKit Bug Importer 2014-01-25 01:26:18 PST 
<rdar://problem/15908842>
Comment 2 Diego Pino 2014-01-25 01:30:43 PST 
Created attachment 222199 [details]
Patch
Comment 3 Joseph Pecoraro 2014-01-25 09:35:06 PST 
Comment on attachment 222199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222199&action=review

Nice! r=me with some style nits.

> Source/WebInspectorUI/ChangeLog:6
> +        Web Inspector: Position the completion suggestions popup below if
> +        there is room enough.
> +
> +        https://bugs.webkit.org/show_bug.cgi?id=127615

Style: `./Tools/Scripts/prepare-ChangeLog -b 127615` would not wrap the title line and would put the bugzilla bug on the next line without an empty line between.

> Source/WebInspectorUI/UserInterface/CompletionSuggestionsView.js:153
> +        // Position the suggestions below the anchor. If there is no room, position the suggestions above

Style: Comments in WebKit are full sentences. This second sentence should end in a period.
Comment 4 Diego Pino 2014-01-25 14:49:08 PST 
Created attachment 222237 [details]
Patch
Comment 5 Joseph Pecoraro 2014-01-25 16:35:23 PST 
Comment on attachment 222237 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2014-01-25 17:03:51 PST 
Comment on attachment 222237 [details]
Patch

Clearing flags on attachment: 222237

Committed r162790: <http://trac.webkit.org/changeset/162790>
Comment 7 WebKit Commit Bot 2014-01-25 17:03:54 PST 
All reviewed patches have been landed.  Closing bug.