Bug 127612 - Clean up SVGPatternElement::collectPatternAttributes
Summary: Clean up SVGPatternElement::collectPatternAttributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-25 00:12 PST by Gyuyoung Kim
Modified: 2014-01-25 19:38 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.78 KB, patch)
2014-01-25 00:14 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (437.48 KB, application/zip)
2014-01-25 01:29 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (471.50 KB, application/zip)
2014-01-25 01:43 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (470.45 KB, application/zip)
2014-01-25 02:46 PST, Build Bot 		no flags Details
Patch (5.89 KB, patch)
2014-01-25 06:57 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-01-25 00:12:38 PST 
This patch refactors SVGPatternElement::collectPatternAttributes() by extracting the setPatternAttributes logic into a new function. This patch also changes the while loop to be easier to understand and similar to collectGradientAttributes.
Comment 1 Gyuyoung Kim 2014-01-25 00:14:05 PST 
Created attachment 222195 [details]
Patch
Comment 2 Gyuyoung Kim 2014-01-25 00:15:19 PST 
Though I think this patch isn't big improvement, this patch will help to understand code readability.
Comment 3 Build Bot 2014-01-25 01:28:58 PST 
Comment on attachment 222195 [details]
Patch

Attachment 222195 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5436325394120704

New failing tests:
svg/custom/js-update-pattern.svg
svg/dynamic-updates/SVGPatternElement-dom-width-attr.html
svg/custom/js-update-pattern-child.svg
svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr.html
http/tests/misc/slow-loading-image-in-pattern.html
svg/W3C-SVG-1.1/pservers-pattern-01-b.svg
svg/W3C-SVG-1.1/pservers-grad-06-b.svg
svg/custom/absolute-root-position-masking.xhtml
svg/transforms/text-with-pattern-with-svg-transform.svg
svg/transforms/text-with-pattern-inside-transformed-html.xhtml
svg/dynamic-updates/SVGPatternElement-dom-x-attr.html
svg/W3C-SVG-1.1/pservers-grad-03-b.svg
svg/dom/viewport-container-crash.svg
svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg
svg/custom/js-late-pattern-and-object-creation.svg
svg/animations/animateTransform-pattern-transform.html
svg/dynamic-updates/SVGPatternElement-dom-height-attr.html
svg/animations/svgenum-animation-1.html
svg/css/composite-shadow-text.svg
svg/stroke/non-scaling-stroke-pattern.svg
svg/W3C-SVG-1.1/coords-units-01-b.svg
svg/custom/deep-dynamic-updates.svg
svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr.html
svg/batik/paints/patternRegionA.svg
svg/W3C-SVG-1.1-SE/pservers-pattern-03-f.svg
svg/batik/paints/patternRegions.svg
svg/batik/paints/patternPreserveAspectRatioA.svg
svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr.html
svg/transforms/transformed-text-fill-pattern.html
svg/custom/js-late-pattern-creation.svg
Comment 4 Build Bot 2014-01-25 01:29:02 PST 
Created attachment 222198 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-01-25 01:43:09 PST 
Comment on attachment 222195 [details]
Patch

Attachment 222195 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4790797513785344

New failing tests:
svg/custom/js-update-pattern.svg
svg/dynamic-updates/SVGPatternElement-dom-width-attr.html
svg/custom/js-update-pattern-child.svg
svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr.html
http/tests/misc/slow-loading-image-in-pattern.html
svg/W3C-SVG-1.1/pservers-pattern-01-b.svg
svg/W3C-SVG-1.1/pservers-grad-06-b.svg
svg/custom/absolute-root-position-masking.xhtml
svg/transforms/text-with-pattern-with-svg-transform.svg
svg/transforms/text-with-pattern-inside-transformed-html.xhtml
svg/dynamic-updates/SVGPatternElement-dom-x-attr.html
svg/W3C-SVG-1.1/pservers-grad-03-b.svg
svg/dom/viewport-container-crash.svg
svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg
svg/custom/js-late-pattern-and-object-creation.svg
svg/animations/animateTransform-pattern-transform.html
svg/dynamic-updates/SVGPatternElement-dom-height-attr.html
svg/animations/svgenum-animation-1.html
svg/css/composite-shadow-text.svg
svg/stroke/non-scaling-stroke-pattern.svg
svg/W3C-SVG-1.1/coords-units-01-b.svg
svg/custom/deep-dynamic-updates.svg
svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr.html
svg/batik/paints/patternRegionA.svg
svg/W3C-SVG-1.1-SE/pservers-pattern-03-f.svg
svg/batik/paints/patternRegions.svg
svg/batik/paints/patternPreserveAspectRatioA.svg
svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr.html
svg/transforms/transformed-text-fill-pattern.html
svg/custom/js-late-pattern-creation.svg
Comment 6 Build Bot 2014-01-25 01:43:12 PST 
Created attachment 222200 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-01-25 02:45:59 PST 
Comment on attachment 222195 [details]
Patch

Attachment 222195 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5153050087915520

New failing tests:
svg/custom/js-update-pattern.svg
svg/dynamic-updates/SVGPatternElement-dom-width-attr.html
svg/custom/js-update-pattern-child.svg
svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr.html
http/tests/misc/slow-loading-image-in-pattern.html
svg/W3C-SVG-1.1/pservers-pattern-01-b.svg
svg/W3C-SVG-1.1/pservers-grad-06-b.svg
svg/custom/absolute-root-position-masking.xhtml
svg/transforms/text-with-pattern-with-svg-transform.svg
svg/transforms/text-with-pattern-inside-transformed-html.xhtml
svg/dynamic-updates/SVGPatternElement-dom-x-attr.html
svg/W3C-SVG-1.1/pservers-grad-03-b.svg
svg/dom/viewport-container-crash.svg
svg/W3C-SVG-1.1-SE/pservers-pattern-04-f.svg
svg/custom/js-late-pattern-and-object-creation.svg
svg/animations/animateTransform-pattern-transform.html
svg/dynamic-updates/SVGPatternElement-dom-height-attr.html
svg/animations/svgenum-animation-1.html
svg/css/composite-shadow-text.svg
svg/stroke/non-scaling-stroke-pattern.svg
svg/W3C-SVG-1.1/coords-units-01-b.svg
svg/custom/deep-dynamic-updates.svg
svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr.html
svg/batik/paints/patternRegionA.svg
svg/W3C-SVG-1.1-SE/pservers-pattern-03-f.svg
svg/batik/paints/patternRegions.svg
svg/batik/paints/patternPreserveAspectRatioA.svg
svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr.html
svg/transforms/transformed-text-fill-pattern.html
svg/custom/js-late-pattern-creation.svg
Comment 8 Build Bot 2014-01-25 02:46:03 PST 
Created attachment 222203 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Gyuyoung Kim 2014-01-25 06:57:55 PST 
Created attachment 222209 [details]
Patch
Comment 10 WebKit Commit Bot 2014-01-25 19:38:50 PST 
Comment on attachment 222209 [details]
Patch

Clearing flags on attachment: 222209

Committed r162792: <http://trac.webkit.org/changeset/162792>
Comment 11 WebKit Commit Bot 2014-01-25 19:38:53 PST 
All reviewed patches have been landed.  Closing bug.