Bug 127592 – IDB: Refactor out the last of the operation callbacks that are called by the LevelDB backing store

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

IDB: Refactor out the last of the operation callbacks that are called by the LevelDB backing store

The backing store has no business knowing what an IDBCallback is.

This is like http://trac.webkit.org/changeset/162501 and http://trac.webkit.org/changeset/162569 but for all remaining cases.

[Brady Eidson]

Created attachment 222341 [details]
Patch v1

[WebKit Commit Bot]

Attachment 222341 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:157:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:178:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:194:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 222341 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222341&action=review

> Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:459
> +        // FIXME: Is failure to have a backing store cursor an error?

is english?

[Tim Horton]

(In reply to comment #3)
> (From update of attachment 222341 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222341&action=review
> 
> > Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:459
> > +        // FIXME: Is failure to have a backing store cursor an error?
> 
> is english?

is english! I just don't read it.

[Brady Eidson]

http://trac.webkit.org/changeset/162856