Bug 127592 - IDB: Refactor out the last of the operation callbacks that are called by the LevelDB backing store
Summary: IDB: Refactor out the last of the operation callbacks that are called by the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 124521
  Show dependency treegraph
 
Reported: 2014-01-24 16:25 PST by Brady Eidson
Modified: 2014-01-27 12:30 PST (History)
4 users (show)

See Also:


Attachments
Patch v1 (19.73 KB, patch)
2014-01-27 11:35 PST, Brady Eidson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-01-24 16:25:52 PST
IDB: Refactor out the last of the operation callbacks that are called by the LevelDB backing store

The backing store has no business knowing what an IDBCallback is.

This is like http://trac.webkit.org/changeset/162501 and http://trac.webkit.org/changeset/162569 but for all remaining cases.
Comment 1 Brady Eidson 2014-01-27 11:35:48 PST
Created attachment 222341 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-01-27 11:37:49 PST
Attachment 222341 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:157:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:178:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:194:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-01-27 11:40:13 PST
Comment on attachment 222341 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222341&action=review

> Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:459
> +        // FIXME: Is failure to have a backing store cursor an error?

is english?
Comment 4 Tim Horton 2014-01-27 11:40:34 PST
(In reply to comment #3)
> (From update of attachment 222341 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222341&action=review
> 
> > Source/WebCore/Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:459
> > +        // FIXME: Is failure to have a backing store cursor an error?
> 
> is english?

is english! I just don't read it.
Comment 5 Brady Eidson 2014-01-27 12:30:51 PST
http://trac.webkit.org/changeset/162856