Bug 127589 – GetTypedArrayOffset in FTL

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Matthew Mirman]

patch forthcoming

[Matthew Mirman]

Created attachment 222159 [details]
GetTypedArrayOffset in FTL implemented

added two test cases for this.

[WebKit Commit Bot]

Attachment 222159 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-wasteful.js:2:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-wasteful.js:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-wasteful.js:10:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1472:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1473:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-simple.js:2:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-simple.js:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-simple.js:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 8 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Comment on attachment 222159 [details]
GetTypedArrayOffset in FTL implemented

View in context: https://bugs.webkit.org/attachment.cgi?id=222159&action=review

Almost there but fix style.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1629
> +        m_out.branch( m_out.notEqual( baseAddress , m_out.constIntPtr(WastefulTypedArray))
> +                    , simpleCase
> +                    , wastefulCase
> +                    );

Bad style:

- Shouldn't have a space between "branch(" and "m_out", and then again between "notEqual(" and "baseAddress".  In general we don't do spaces between the open paren and the stuff inside.

- Should put the commas on the previous line at those linebreaks.

- When you wrap a line, always indent 4 spaces and never more.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:1651
> +        // output

You probably don't need this comment.

[Matthew Mirman]

Created attachment 222168 [details]
GetTypedArrayOffset in FTL implemented

fixed whitespace in last version.

[WebKit Commit Bot]

Attachment 222168 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-wasteful.js:2:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-wasteful.js:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-wasteful.js:10:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-simple.js:2:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-simple.js:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/ftl-gettypedarrayoffset-simple.js:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 6 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Matthew Mirman]

Created attachment 222169 [details]
GetTypedArrayOffset in FTL implemented

Fixed even more whitespace

[Matthew Mirman]

Created attachment 222178 [details]
GetTypedArrayOffset in FTL implemented

Even more whitespace fixes.

[Geoffrey Garen]

FYI, you should be able to emacs-mode your way out of future whitespace problems.

[WebKit Commit Bot]

Comment on attachment 222178 [details]
GetTypedArrayOffset in FTL implemented

Clearing flags on attachment: 222178

Committed r163324: <http://trac.webkit.org/changeset/163324>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.