Bug 127584 - [New Multicolumn] Don't destroy all the renderers when a multi-column block stops being multi-column (and vice versa)
Summary: [New Multicolumn] Don't destroy all the renderers when a multi-column block s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-24 13:56 PST by Dave Hyatt
Modified: 2014-01-24 14:48 PST (History)
5 users (show)

See Also:

Attachments
Patch (22.72 KB, patch)
2014-01-24 14:02 PST, Dave Hyatt 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2014-01-24 13:56:28 PST 
Don't destroy all the renderers when a multi-column block stops being multi-column (and vice versa). We make the logic for this share with the old multi-column code so that the two are closer in line.
Comment 1 Dave Hyatt 2014-01-24 14:02:37 PST 
Created attachment 222153 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-24 14:03:42 PST 
Attachment 222153 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlockFlow.h:435:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2014-01-24 14:48:21 PST 
Landed in r162726.