Bug 127580 - Replace LayoutUnit() calls to a more descriptive LayoutUnit::fromPixel(int).
Summary: Replace LayoutUnit() calls to a more descriptive LayoutUnit::fromPixel(int).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on: 127562
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-24 13:30 PST by zalan
Modified: 2014-01-28 00:43 PST (History)
6 users (show)

See Also:


Attachments
Patch (9.95 KB, patch)
2014-01-24 14:23 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-01-24 13:30:45 PST
LayoutUnit(1) is highly ambiguous. It is intended to set one (CSS) pixel, but it could read as 1 layout unit (1/64th of pixel atm)
Comment 1 zalan 2014-01-24 14:23:40 PST
Created attachment 222155 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-24 16:17:31 PST
Comment on attachment 222155 [details]
Patch

Clearing flags on attachment: 222155

Committed r162737: <http://trac.webkit.org/changeset/162737>
Comment 3 WebKit Commit Bot 2014-01-24 16:17:33 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2014-01-28 00:43:08 PST
<rdar://problem/15923398>