Bug 127571 – Get rid of monotonicallyIncreasingTimeMS and start using std::chrono instead

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Get rid of monotonicallyIncreasingTimeMS and start using std::chrono instead

[Anders Carlsson]

Created attachment 222129 [details]
Patch

[WebKit Commit Bot]

Attachment 222129 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/StdLibExtras.h:405:  Do not use 'using namespace std::literals::chrono_literals;'.  [build/using_namespace] [4]
ERROR: Source/WTF/wtf/StdLibExtras.h:405:  std::literals::chrono_literals is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 222129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222129&action=review

> Source/WTF/wtf/StdLibExtras.h:380
> +    namespace literals {
> +        namespace chrono_literals {
> +            CONSTEXPR inline chrono::seconds operator"" _s(unsigned long long s)

We don't usually indent namespace content.

> Source/WebCore/page/Settings.cpp:149
> -static const int layoutScheduleThreshold = 250;
> +static const auto layoutScheduleThreshold = 250_ms;

nice!

[Anders Carlsson]

Created attachment 222133 [details]
Patch

[WebKit Commit Bot]

Attachment 222133 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/StdLibExtras.h:408:  Do not use 'using namespace std::literals::chrono_literals;'.  [build/using_namespace] [4]
ERROR: Source/WTF/wtf/StdLibExtras.h:408:  std::literals::chrono_literals is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Committed r162716: <http://trac.webkit.org/changeset/162716>