Bug 127567 - Skip op_profiler callbacks if !VM::m_enabledProfiler
Summary: Skip op_profiler callbacks if !VM::m_enabledProfiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-24 10:43 PST by Mark Lam
Modified: 2014-01-24 13:20 PST (History)
7 users (show)

See Also:

Attachments
the patch. (11.33 KB, patch)
2014-01-24 11:11 PST, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-01-24 10:43:15 PST 
The profiler may not be always active (recording).  When it's not active (as in VM::m_enabledProfiler is null), then we might as well skip the op_profiler callbacks.  The callbacks themselves are already gated by a VM::enabledProfiler() check.  For the DFG, we'll turn the op_profiler handling into speculation checks and OSR exit to the baseline JIT if the profiler becomes active.
Comment 1 Mark Lam 2014-01-24 11:11:59 PST 
Created attachment 222121 [details]
the patch.
Comment 2 Geoffrey Garen 2014-01-24 11:20:53 PST 
Comment on attachment 222121 [details]
the patch.

r=me

Any speedup here?
Comment 3 Geoffrey Garen 2014-01-24 11:21:14 PST 
Ah, I see: "This brings the Octane score up to ~3000 from ~2840."
Comment 4 Mark Lam 2014-01-24 13:20:18 PST 
Thanks.  The patch has passed the layout tests.

Landed in r162718: <http://trac.webkit.org/r162718>.