RESOLVED WORKSFORME127556
Rename various RenderFlexibleBox variables and arguments to match the naming from the spec 
https://bugs.webkit.org/show_bug.cgi?id=127556
Summary Rename various RenderFlexibleBox variables and arguments to match the naming ...
Peter Molnar
Reported 2014-01-24 07:24:29 PST
This should make it easier to understand the code. I have also simplified some calculations and gave some expressions their own variables. Merged from Blink: https://src.chromium.org/viewvc/blink?revision=153288&view=revision
Attachments
patch (6.99 KB, patch)
2014-01-24 07:25 PST, Peter Molnar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Molnar
Comment 1 2014-01-24 07:25:28 PST
Created attachment 222107 [details] patch
Michael Catanzaro
Comment 2 2016-09-17 07:19:03 PDT
Comment on attachment 222107 [details] patch Hi, Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting. To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.
Sergio Villar Senin
Comment 3 2021-09-13 01:14:44 PDT
Right, this was already fixed in r213149 BTW.
Note You need to log in before you can comment on or make changes to this bug.