Bug 127556 - Rename various RenderFlexibleBox variables and arguments to match the naming from the spec
Summary: Rename various RenderFlexibleBox variables and arguments to match the naming ...
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2014-01-24 07:24 PST by Peter Molnar
Modified: 2021-09-13 01:14 PDT (History)
8 users (show)

See Also:

Attachments
patch (6.99 KB, patch)
2014-01-24 07:25 PST, Peter Molnar 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Molnar 2014-01-24 07:24:29 PST 
This should make it easier to understand the code. I have also simplified some calculations
and gave some expressions their own variables.

Merged from Blink: https://src.chromium.org/viewvc/blink?revision=153288&view=revision
Comment 1 Peter Molnar 2014-01-24 07:25:28 PST 
Created attachment 222107 [details]
patch
Comment 2 Michael Catanzaro 2016-09-17 07:19:03 PDT 
Comment on attachment 222107 [details]
patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.
Comment 3 Sergio Villar Senin 2021-09-13 01:14:44 PDT 
Right, this was already fixed in r213149 BTW.