Add web_timing informations.
Created attachment 222094 [details] proposed patch Access timing information related to navigation.
Created attachment 222106 [details] proposed patch
Comment on attachment 222106 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=222106&action=review Looks good, but I had a question about the removal of a "didReceiveResponse" call. Also, you accidentally introduced a blank line. > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:-468 > - client->didReceiveResponse(job, d->m_response); Why don't we need this call to didReceiveResponse anymore? Does CurlCacheManager do this work as well? > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:657 > + Extra blank line!
(In reply to comment #3) > Why don't we need this call to didReceiveResponse anymore? Does CurlCacheManager do this work as well? No it doesn't, only the function name is similar.
(In reply to comment #3) > (From update of attachment 222106 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222106&action=review > > Looks good, but I had a question about the removal of a "didReceiveResponse" call. Also, you accidentally introduced a blank line. > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:-468 > > - client->didReceiveResponse(job, d->m_response); > > Why don't we need this call to didReceiveResponse anymore? Does CurlCacheManager do this work as well? > > > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:657 > > + > > Extra blank line! Instead of calling didReceiveResponse from the headerCallback function, I call it from downloadTimerCallback (and from dispatchSynchronousJob in synchronous case) to make sure that the webtiming informations will be retrieved and set properly.
Comment on attachment 222106 [details] proposed patch r=me
Comment on attachment 222106 [details] proposed patch Clearing flags on attachment: 222106 Committed r167377: <http://trac.webkit.org/changeset/167377>
All reviewed patches have been landed. Closing bug.