Bug 127552 – Fix build warnings by unused parameter

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit Misc.

[Jinwoo Song]

In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebLoaderClient.h:30:0,
                 from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.h:55,
                 from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:28:
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APILoaderClient.h:90:18: warning: unused parameter ‘addedItem’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APILoaderClient.h:90:18: warning: unused parameter ‘removedItems’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APILoaderClient.h:94:44: warning: unused parameter ‘unavailabilityDescription’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APILoaderClient.h:94:44: warning: unused parameter ‘useBlockedPluginTitle’ [-Wunused-parameter]
In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:32:0:
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:53:18: warning: unused parameter ‘originatingFrame’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:53:18: warning: unused parameter ‘originalRequest’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:53:18: warning: unused parameter ‘userData’ [-Wunused-parameter]
In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/WebPageProxy.cpp:32:0:
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:54:18: warning: unused parameter ‘frameName’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:54:18: warning: unused parameter ‘userData’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:55:18: warning: unused parameter ‘canShowMIMEType’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:55:18: warning: unused parameter ‘userData’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/UIProcess/API/APIPolicyClient.h:56:18: warning: unused parameter ‘userData’ [-Wunused-parameter]

/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:499:6: warning: unused parameter ‘changed’ [-Wunused-parameter]

/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:617:26: warning: unused parameter ‘frame’ [-Wunused-parameter]
/mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2090:6: warning: unused parameter ‘isInitialState’ [-Wunused-parameter]

[Jinwoo Song]

Created attachment 222090 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 222090 [details]
Patch

LGTM

[Anders Carlsson]

Comment on attachment 222090 [details]
Patch

I think you can just remove the parameters instead of commenting them out.

[Jinwoo Song]

(In reply to comment #3)
> (From update of attachment 222090 [details])
> I think you can just remove the parameters instead of commenting them out.

I commented out the parameters which can not infer the meanings from the parameter types because that was a consensus discussed before as I know.

[Gyuyoung Kim]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 222090 [details] [details])
> > I think you can just remove the parameters instead of commenting them out.
> 
> I commented out the parameters which can not infer the meanings from the parameter types because that was a consensus discussed before as I know.

There is a rule by Darin, https://lists.webkit.org/pipermail/webkit-dev/2012-October/022369.html

Personally, I also prefer to remove parameter name in this case :)

[Csaba Osztrogonác]

There is no warning now.