RESOLVED FIXED 127530
Web Inspector: Refactor bar combining logic into a TimelineRecordBar helper 
https://bugs.webkit.org/show_bug.cgi?id=127530
Summary Web Inspector: Refactor bar combining logic into a TimelineRecordBar helper
Timothy Hatcher
Reported 2014-01-23 18:10:19 PST
This will let NetworkTimelineOverviewGraph use TimelineRecordBar.
Attachments
Patch (38.34 KB, patch)
2014-01-23 18:22 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
Screenshot (404.91 KB, image/png)
2014-01-23 18:23 PST, Timothy Hatcher 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-23 18:11:07 PST
<rdar://problem/15898755>
Timothy Hatcher
Comment 2 2014-01-23 18:22:22 PST
Created attachment 222063 [details] Patch
Timothy Hatcher
Comment 3 2014-01-23 18:23:36 PST
Created attachment 222065 [details] Screenshot
Joseph Pecoraro
Comment 4 2014-01-23 19:09:39 PST
Comment on attachment 222063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222063&action=review Clean! r=me > Source/WebInspectorUI/ChangeLog:49 > + Lazy create DOM elements. Support rendering one or both segments. Doing this lets Typo: Lazy => Lazily > Source/WebInspectorUI/ChangeLog:50 > + combined inactive segments to sit behind multiple active segments. Typo: "combined inactive segments to sit" => "combined inactive segments sit" > Source/WebInspectorUI/UserInterface/NetworkTimelineOverviewGraph.css:27 > + padding-top: 3px Nit: Missing semicolon. > Source/WebInspectorUI/UserInterface/TimelineRecordBar.js:238 > + var barEndTime = this._records.reduce(function(previousValue, currentValue) { return Math.max(previousValue, currentValue.endTime); }, 0); The list is no longer sorted? Nit: Up above, out of context, there is a "return;" that should be "return false;"
Timothy Hatcher
Comment 5 2014-01-23 19:37:32 PST
https://trac.webkit.org/r162681
Note You need to log in before you can comment on or make changes to this bug.