Bug 127528 - Set full URLs for kLSActivePageUserVisibleOriginsKey
Summary: Set full URLs for kLSActivePageUserVisibleOriginsKey
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 525.x (Safari 3.1)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 17:54 PST by Gavin Barraclough
Modified: 2014-02-10 01:18 PST (History)
0 users

See Also:

Attachments
Fix (1.94 KB, patch)
2014-01-23 17:55 PST, Gavin Barraclough 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-01-23 17:54:01 PST 
In many cases the domain name is not sufficiently useful.
Comment 1 Gavin Barraclough 2014-01-23 17:55:22 PST 
Created attachment 222052 [details]
Fix
Comment 2 Mark Rowe (bdash) 2014-01-25 14:35:09 PST 
Comment on attachment 222052 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=222052&action=review

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:240
> +        NSURL *originAsNSURL = [NSURL URLWithString:mainFrame->url()];

Elsewhere in WebKit2 we use +_web_URLWithWTFString: to convert from a String representation of a URL to NSURL. Should we do the same here?