Bug 127527 - Add an APILoaderClient base class
Summary: Add an APILoaderClient base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 17:42 PST by Anders Carlsson
Modified: 2014-01-23 17:55 PST (History)
0 users

See Also:

Attachments
Patch (42.21 KB, patch)
2014-01-23 17:48 PST, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-23 17:42:54 PST 
Add an APILoaderClient base class
Comment 1 Anders Carlsson 2014-01-23 17:48:27 PST 
Created attachment 222051 [details]
Patch
Comment 2 Tim Horton 2014-01-23 17:51:22 PST 
Comment on attachment 222051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222051&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm:811
> -    return (WKBrowsingContextController *)WebKit::toImpl(pageRef)->loaderClient().client().base.clientInfo;
> +//    return (WKBrowsingContextController *)WebKit::toImpl(pageRef)->loaderClient()->client().base.clientInfo;
> +    return 0;

wut
Comment 3 Tim Horton 2014-01-23 17:52:07 PST 
Comment on attachment 222051 [details]
Patch

other than that, seems fine
Comment 4 Anders Carlsson 2014-01-23 17:55:42 PST 
Committed r162670: <http://trac.webkit.org/changeset/162670>