WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
127527
Add an APILoaderClient base class
https://bugs.webkit.org/show_bug.cgi?id=127527
Summary
Add an APILoaderClient base class
Anders Carlsson
Reported
2014-01-23 17:42:54 PST
Add an APILoaderClient base class
Attachments
Patch
(42.21 KB, patch)
2014-01-23 17:48 PST
,
Anders Carlsson
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-01-23 17:48:27 PST
Created
attachment 222051
[details]
Patch
Tim Horton
Comment 2
2014-01-23 17:51:22 PST
Comment on
attachment 222051
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=222051&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm:811 > - return (WKBrowsingContextController *)WebKit::toImpl(pageRef)->loaderClient().client().base.clientInfo; > +// return (WKBrowsingContextController *)WebKit::toImpl(pageRef)->loaderClient()->client().base.clientInfo; > + return 0;
wut
Tim Horton
Comment 3
2014-01-23 17:52:07 PST
Comment on
attachment 222051
[details]
Patch other than that, seems fine
Anders Carlsson
Comment 4
2014-01-23 17:55:42 PST
Committed
r162670
: <
http://trac.webkit.org/changeset/162670
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug