Bug 127526 - Move RegularExpression into JavaScriptCore for inspector
Summary: Move RegularExpression into JavaScriptCore for inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 17:15 PST by Joseph Pecoraro
Modified: 2014-01-23 22:06 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (51.96 KB, patch)
2014-01-23 17:18 PST, Joseph Pecoraro 		ggaren: review+
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (47.00 KB, patch)
2014-01-23 19:23 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-23 17:15:12 PST 
The Inspector will soon need to use RegularExpressions. The current implementation in platform/text only relies on JavaScriptCore/yarr and wtf. Lets move it into JavaScriptCore so the inspector can use it.

I'm going to put it in the JSC::Yarr namespace. Let me know if something else might be better.
Comment 1 Joseph Pecoraro 2014-01-23 17:18:20 PST 
Created attachment 222047 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-01-23 17:20:27 PST 
Attachment 222047 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/yarr/RegularExpression.cpp:175:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2014-01-23 19:16:46 PST 
Comment on attachment 222047 [details]
[PATCH] Proposed Fix

r=me if you fix the build
Comment 4 Joseph Pecoraro 2014-01-23 19:23:32 PST 
Created attachment 222069 [details]
[PATCH] Proposed Fix

Patch for bots. I had a bunch of future code in the patch. This is the patch rebased onto ToT.
Comment 5 Joseph Pecoraro 2014-01-23 22:06:10 PST 
Landed <http://trac.webkit.org/changeset/162691>.