WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
127520
Explicitly link XPC services with AppKit
https://bugs.webkit.org/show_bug.cgi?id=127520
Summary
Explicitly link XPC services with AppKit
Anders Carlsson
Reported
2014-01-23 15:51:39 PST
Explicitly link XPC services with AppKit
Attachments
Patch
(5.08 KB, patch)
2014-01-23 15:53 PST
,
Anders Carlsson
mrowe
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-01-23 15:53:21 PST
Created
attachment 222034
[details]
Patch
Mark Rowe (bdash)
Comment 2
2014-01-23 15:55:19 PST
Comment on
attachment 222034
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=222034&action=review
> Source/WebKit2/ChangeLog:3 > + Explicitly link XPC services with AppKit
You're only doing this to a subset of the XPC services. It might be worth mentioning why that subset is special.
> Source/WebKit2/Configurations/PluginService.64.xcconfig:38 > +FRAMEWORK_LDFLAGS = -framework Foundation $(FRAMEWORK_LDFLAGS_$(DEBUG_OR_RELEASE));
May as well revert this bit.
Anders Carlsson
Comment 3
2014-01-23 15:57:09 PST
Committed
r162658
: <
http://trac.webkit.org/changeset/162658
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug