Bug 127520 - Explicitly link XPC services with AppKit
Summary: Explicitly link XPC services with AppKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 15:51 PST by Anders Carlsson
Modified: 2014-01-23 15:57 PST (History)
0 users

See Also:


Attachments
Patch (5.08 KB, patch)
2014-01-23 15:53 PST, Anders Carlsson
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-23 15:51:39 PST
Explicitly link XPC services with AppKit
Comment 1 Anders Carlsson 2014-01-23 15:53:21 PST
Created attachment 222034 [details]
Patch
Comment 2 Mark Rowe (bdash) 2014-01-23 15:55:19 PST
Comment on attachment 222034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222034&action=review

> Source/WebKit2/ChangeLog:3
> +        Explicitly link XPC services with AppKit

You're only doing this to a subset of the XPC services. It might be worth mentioning why that subset is special.

> Source/WebKit2/Configurations/PluginService.64.xcconfig:38
> +FRAMEWORK_LDFLAGS = -framework Foundation  $(FRAMEWORK_LDFLAGS_$(DEBUG_OR_RELEASE));

May as well revert this bit.
Comment 3 Anders Carlsson 2014-01-23 15:57:09 PST
Committed r162658: <http://trac.webkit.org/changeset/162658>