Bug 127505 - [iOS] Protect against possible deadlock by delaying video layer creation
Summary: [iOS] Protect against possible deadlock by delaying video layer creation
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 12:31 PST by Jer Noble
Modified: 2014-01-25 07:41 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2014-01-23 12:36 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (2.66 KB, patch)
2014-01-23 13:47 PST, Jer Noble 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (2.66 KB, patch)
2014-01-23 20:35 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-01-23 12:31:37 PST 
[Mac] Protect against possbile deadlock by delaying video layer creation
Comment 1 Jer Noble 2014-01-23 12:36:54 PST 
Created attachment 222017 [details]
Patch
Comment 2 Eric Carlson 2014-01-23 12:40:48 PST 
Comment on attachment 222017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222017&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:429
>      if (!m_videoLayer) {

You could add "|| m_videoLayer" to the early return above and get rid of this test.
Comment 3 Eric Carlson 2014-01-23 13:04:35 PST 
Comment on attachment 222017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222017&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:430
> +        callOnMainThread([this] {

This should return if m_videoLayer is non-NULL.
Comment 4 Jer Noble 2014-01-23 13:47:50 PST 
Created attachment 222025 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2014-01-23 20:27:47 PST 
Comment on attachment 222025 [details]
Patch for landing

Rejecting attachment 222025 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 222025, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6479526041223168
Comment 6 Jer Noble 2014-01-23 20:35:35 PST 
Created attachment 222072 [details]
Patch for landing
Comment 7 Jer Noble 2014-01-23 20:36:07 PST 
Comment on attachment 222072 [details]
Patch for landing

Now with fewer OOPS.
Comment 8 WebKit Commit Bot 2014-01-23 21:11:11 PST 
Comment on attachment 222072 [details]
Patch for landing

Clearing flags on attachment: 222072

Committed r162686: <http://trac.webkit.org/changeset/162686>