Bug 127496 - [EFL][WK2] Debug buildfix
Summary: [EFL][WK2] Debug buildfix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
: 127549 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-23 10:46 PST by Csaba Osztrogonác
Modified: 2014-01-24 04:04 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.16 KB, patch)
2014-01-23 10:50 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-01-23 10:46:11 PST 
On Ubuntu 12.04 with GCC 4.7.3 (Ubuntu/Linaro 4.7.3-2ubuntu1~12.04)
I got the following build failure only in debug mode:

$ Tools/Scripts/build-webkit --debug --efl --cmakeargs="-DSHARED_CORE=ON"

Linking CXX shared library ../../lib/libewebkit2.so
CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebPage.cpp.o: In function `WebKit::WebPage::sessionID() const':
/home/ossy/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2130: undefined reference to `WebKit::SessionTracker::legacyPrivateSessionID'
/home/ossy/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2130: undefined reference to `WebKit::SessionTracker::defaultSessionID'
collect2: error: ld returned 1 exit status
make[2]: *** [lib/libewebkit2.so.0.1.0] Error 1
make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
make: *** [all] Error 2
Comment 1 Csaba Osztrogonác 2014-01-23 10:50:03 PST 
Created attachment 222002 [details]
Patch
Comment 2 Gyuyoung Kim 2014-01-24 03:55:04 PST 
*** Bug 127549 has been marked as a duplicate of this bug. ***
Comment 3 Csaba Osztrogonác 2014-01-24 03:59:12 PST 
landed in r162699
Comment 4 Gyuyoung Kim 2014-01-24 04:01:37 PST 
(In reply to comment #3)
> landed in r162699

This patch belong to WK2 owner area, this patch is to fix build error. So, I believe this doesn't violate WK2 owner policy.
Comment 5 Csaba Osztrogonác 2014-01-24 04:03:37 PST 
Trivial buildfixes don't need owner review.
Comment 6 Gyuyoung Kim 2014-01-24 04:04:40 PST 
(In reply to comment #5)
> Trivial buildfixes don't need owner review.

I see. :D Thanks.