Bug 127483 - Merge Chromium TextTrack cleanups
Summary: Merge Chromium TextTrack cleanups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 08:37 PST by Eric Carlson
Modified: 2014-01-27 07:03 PST (History)
6 users (show)

See Also:

Attachments
Proposed patch (13.95 KB, text/plain)
2014-01-23 08:50 PST, Eric Carlson 		darin: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-01-23 08:37:13 PST 
Merge some of the Chromium TextTrack cleanups that have happened since the fork.
Comment 1 Eric Carlson 2014-01-23 08:50:00 PST 
Created attachment 221986 [details]
Proposed patch
Comment 2 Darin Adler 2014-01-23 09:46:53 PST 
Comment on attachment 221986 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221986&action=review

> Source/WebCore/html/HTMLTrackElement.h:91
> +    bool canLoadUrl(const URL&);

Should be named canLoadURL.

> Source/WebCore/loader/TextTrackLoader.cpp:79
> +        m_resource = 0;

nullptr
Comment 3 Eric Carlson 2014-01-27 07:03:09 PST 
Committed r162836: http://trac.webkit.org/changeset/162836