Bug 127481 – [GTK] webkit_web_view_load_html reads UTF8 css files as UTF16

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Sami Wagiaalla]

If you use webkit_web_view_load_html and provide an HTML string which contains links to css files webkit expects those files to be UTF16. Even if the default charset was set to UTF8.

[Sami Wagiaalla]

Created attachment 221983 [details]
a small test case

[Pascal Jacquemart]

Hi Samy,

I gave a quick try on your reduced test case but it seems to work properly for me. Launching your browser example and the text is actually displayed in blue
Am I missing something?

[Sami Wagiaalla]

Hi!

> I gave a quick try on your reduced test case but it seems to work properly for me. Launching your browser example and the text is actually displayed in blue

Hmm.. I did not expect that.
Which version of webkitgtk are you using ?

Is there any reason (setting on your environment) for your webkit to read the css file correctly as UTF8 ?

Just out of curiosity what happens of you replace the test.css file with test16.css file (mv test16.css test.css) ?

Strangely it turns out that if you specify @charset "UTF16" in the CSS file it is read properly.

[Pascal Jacquemart]

I tried with r162697 

Replacing test16.css to test.css give the same result: Big blue text
Of course while removing both .css files the text is flat

Maybe this issue is already fixed on the trunk?

[Sami Wagiaalla]

> Maybe this issue is already fixed on the trunk?

That would be great! Let me try trunk...

[Sami Wagiaalla]

Hi Pascal,

> > Maybe this issue is already fixed on the trunk? 
> That would be great! Let me try trunk...

Looks like you were right about this. The issue was fixed in revision 160572. Specifically http://trac.webkit.org/changeset/160572/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

Any chance of back-porting that change to a stable release ?

[Carlos Garcia Campos]

Sure, added to the wiki https://trac.webkit.org/wiki/WebKitGTK/2.2.x

[Sami Wagiaalla]

Created attachment 222994 [details]
A partial back ported patch which fixes this issue

[Sami Wagiaalla]

(In reply to comment #7)
> Sure, added to the wiki https://trac.webkit.org/wiki/WebKitGTK/2.2.x

Thanks Carlos. I have attached the part of the patch which fixes this issue.

[Carlos Garcia Campos]

Committed in http://trac.webkit.org/changeset/164280. Thanks!

[Sami Wagiaalla]

> Committed in http://trac.webkit.org/changeset/164280. Thanks!

Sweet! Thanks Carlos!