Bug 127471 – [iOS] [WK2] WKContentView has a black background

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

... which is frequently exposed during loading.

It shouldn't be black (it shouldn't need a background at all!).

<rdar://problem/12287363>

[Tim Horton]

Created attachment 221961 [details]
patch

[Ian Henderson]

Comment on attachment 221961 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review

> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:52
> +@end

Is this how we deal with private headers on the Mac?  Why even include the private header if we're going to make this category?

[Sam Weinig]

Comment on attachment 221961 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review

>> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:52
>> +@end
> 
> Is this how we deal with private headers on the Mac?  Why even include the private header if we're going to make this category?

I think we usually do the category as an #else clause.

[Sam Weinig]

(In reply to comment #3)
> (From update of attachment 221961 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review
> 
> >> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:52
> >> +@end
> > 
> > Is this how we deal with private headers on the Mac?  Why even include the private header if we're going to make this category?
> 
> I think we usually do the category as an #else clause.

Oh, and reason we do it is to catch errors for people who have the header.

[Tim Horton]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 221961 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review
> > 
> > >> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:52
> > >> +@end
> > > 
> > > Is this how we deal with private headers on the Mac?  Why even include the private header if we're going to make this category?
> > 
> > I think we usually do the category as an #else clause.
> 
> Oh, and reason we do it is to catch errors for people who have the header.

Exactly.

If we put it in an #else, we wouldn't (as readily) catch signature changes. I think the only case we use a #else is if we need to magic the class itself into existence (when the class itself is also private).

[Anders Carlsson]

Comment on attachment 221961 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review

> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:46
> +#if defined(__has_include) && __has_include(<QuartzCore/QuartzCorePrivate.h>)

Do we really need the #if defined(__has_include) part here?

[Tim Horton]

(In reply to comment #6)
> (From update of attachment 221961 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221961&action=review
> 
> > Source/WebKit2/UIProcess/API/ios/WKContentView.mm:46
> > +#if defined(__has_include) && __has_include(<QuartzCore/QuartzCorePrivate.h>)
> 
> Do we really need the #if defined(__has_include) part here?

I don’t think we do anymore (or maybe ever?)

[Tim Horton]

http://trac.webkit.org/changeset/162626