Bug 127470 - Remove unused RuntimeEnabledFeatures
Summary: Remove unused RuntimeEnabledFeatures
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-23 01:14 PST by Allan Sandfeld Jensen
Modified: 2014-01-24 00:07 PST (History)
1 user (show)

See Also:

Attachments
Patch (3.20 KB, patch)
2014-01-23 01:16 PST, Allan Sandfeld Jensen 		ap: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2014-01-23 01:14:47 PST 
Remove the unused indexedDBEnabled(), webSocketEnabled() and sharedWorkerEnabled(). Their presence is only confusing.
Comment 1 Allan Sandfeld Jensen 2014-01-23 01:16:47 PST 
Created attachment 221960 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-01-23 14:38:07 PST 
Comment on attachment 221960 [details]
Patch

EWS is red, saying that these are used in generated code:

/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow.cpp:4922:51: error: no member named 'webSocketEnabled' in 'WebCore::RuntimeEnabledFeatures'
    if (!RuntimeEnabledFeatures::sharedFeatures().webSocketEnabled())
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow.cpp:8984:51: error: no member named 'sharedWorkerEnabled' in 'WebCore::RuntimeEnabledFeatures'
    if (!RuntimeEnabledFeatures::sharedFeatures().sharedWorkerEnabled())
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

IndexedDB is disabled IIRC, otherwise it would almost certainly fail too.