RESOLVED INVALID 127470
Remove unused RuntimeEnabledFeatures 
https://bugs.webkit.org/show_bug.cgi?id=127470
Summary Remove unused RuntimeEnabledFeatures
Allan Sandfeld Jensen
Reported 2014-01-23 01:14:47 PST
Remove the unused indexedDBEnabled(), webSocketEnabled() and sharedWorkerEnabled(). Their presence is only confusing.
Attachments
Patch (3.20 KB, patch)
2014-01-23 01:16 PST, Allan Sandfeld Jensen 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2014-01-23 01:16:47 PST
Created attachment 221960 [details] Patch
Alexey Proskuryakov
Comment 2 2014-01-23 14:38:07 PST
Comment on attachment 221960 [details] Patch EWS is red, saying that these are used in generated code: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow.cpp:4922:51: error: no member named 'webSocketEnabled' in 'WebCore::RuntimeEnabledFeatures' if (!RuntimeEnabledFeatures::sharedFeatures().webSocketEnabled()) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSDOMWindow.cpp:8984:51: error: no member named 'sharedWorkerEnabled' in 'WebCore::RuntimeEnabledFeatures' if (!RuntimeEnabledFeatures::sharedFeatures().sharedWorkerEnabled()) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ IndexedDB is disabled IIRC, otherwise it would almost certainly fail too.
Note You need to log in before you can comment on or make changes to this bug.