Bug 127457 - [Win] Update project and solution files for 64-bit builds
Summary: [Win] Update project and solution files for 64-bit builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 17:41 PST by Brent Fulgham
Modified: 2014-01-23 10:09 PST (History)
5 users (show)

See Also:


Attachments
Patch against branch. (91.24 KB, patch)
2014-01-22 17:56 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch against ToT (32.18 KB, patch)
2014-01-22 20:32 PST, Brent Fulgham
eric.carlson: review+
bfulgham: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-01-22 17:41:23 PST
This patch updates several projects, solutions, and source code to allow an end-to-end internal Apple build of WebKit in 64-bit mode.
Comment 1 Brent Fulgham 2014-01-22 17:56:36 PST
Created attachment 221930 [details]
Patch against branch.
Comment 2 Brent Fulgham 2014-01-22 20:32:51 PST
Created attachment 221940 [details]
Patch against ToT
Comment 3 WebKit Commit Bot 2014-01-22 20:35:02 PST
Attachment 221940 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:231:  edge_dash_lengths is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:232:  middle_dash_lengths is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:233:  edge_offset is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp:234:  middle_offset is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 4 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Carlson 2014-01-23 09:40:40 PST
Comment on attachment 221940 [details]
Patch against ToT

rs=me
Comment 5 Brent Fulgham 2014-01-23 10:09:45 PST
Committed r162621: <http://trac.webkit.org/changeset/162621>