Bug 127456 - Make visibleContentRect() return actualVisibleContentRect() on iOS most of the time
Summary: Make visibleContentRect() return actualVisibleContentRect() on iOS most of th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 17:33 PST by Simon Fraser (smfr)
Modified: 2014-01-23 16:35 PST (History)
4 users (show)

See Also:

Attachments
Patch (34.97 KB, patch)
2014-01-22 17:51 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (36.80 KB, patch)
2014-01-22 21:11 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (37.12 KB, patch)
2014-01-22 22:05 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (55.21 KB, patch)
2014-01-23 16:29 PST, Simon Fraser (smfr) 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-01-22 17:33:07 PST 
Make visibleContentRect() return actualVisibleContentRect() on iOS most of the time
Comment 1 Simon Fraser (smfr) 2014-01-22 17:51:04 PST 
Created attachment 221928 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-01-22 21:11:00 PST 
Created attachment 221944 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-01-22 22:05:46 PST 
Created attachment 221947 [details]
Patch
Comment 4 Antti Koivisto 2014-01-23 12:11:01 PST 
Comment on attachment 221947 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221947&action=review

> Source/WebCore/platform/ScrollView.h:162
> +    virtual IntRect visibleContentRect(VisibleContentRectIncludesScrollbars = ExcludeScrollbars, VisibleContentRectBehavior = ContentsVisibleRect) const override;

Default values are nasty in general and having more than one especially awkward. Considering that very few call sites want to include the scrollbars I think you should add a separate visibleContentRectIncludingScrollbars() function.
Comment 5 Simon Fraser (smfr) 2014-01-23 16:29:16 PST 
Created attachment 222039 [details]
Patch
Comment 6 Simon Fraser (smfr) 2014-01-23 16:35:29 PST 
https://trac.webkit.org/r162663