Bug 127450 - Update JS whitespace definition for changes in Unicode 6.3
Summary: Update JS whitespace definition for changes in Unicode 6.3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-22 15:32 PST by Alexey Proskuryakov
Modified: 2014-02-03 13:48 PST (History)
4 users (show)

See Also:


Attachments
proposed fix (1.53 KB, patch)
2014-01-22 15:36 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
without tabs (1.54 KB, patch)
2014-01-22 15:46 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff
part 2 (1.41 KB, patch)
2014-02-03 12:43 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-01-22 15:32:26 PST
Unicode 6.3 changes character type of U+180E MONGOLIAN VOWEL SEPARATOR, so that it's no longer whitespace for the purposes of number parsing.

But EcmaScript says that we should keep recognizing it as whitespace, because that's why Unicode 3.0 said: "ECMAScript implementations must recognise all of the white space characters defined in Unicode 3.0. Later editions of the Unicode Standard may define other white space characters. ECMAScript implementations may recognise white space characters from later editions of the Unicode Standard."

<rdar://15863457>
Comment 1 Alexey Proskuryakov 2014-01-22 15:36:30 PST
Created attachment 221916 [details]
proposed fix
Comment 2 WebKit Commit Bot 2014-01-22 15:39:27 PST
Attachment 221916 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-01-22 15:46:15 PST
Created attachment 221918 [details]
without tabs
Comment 4 WebKit Commit Bot 2014-01-22 17:31:26 PST
Comment on attachment 221918 [details]
without tabs

Clearing flags on attachment: 221918

Committed r162575: <http://trac.webkit.org/changeset/162575>
Comment 5 WebKit Commit Bot 2014-01-22 17:31:28 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2014-02-03 12:42:21 PST
There is one more place to update.
Comment 7 Alexey Proskuryakov 2014-02-03 12:43:44 PST
Created attachment 223009 [details]
part 2
Comment 8 WebKit Commit Bot 2014-02-03 13:48:08 PST
Comment on attachment 223009 [details]
part 2

Clearing flags on attachment: 223009

Committed r163325: <http://trac.webkit.org/changeset/163325>
Comment 9 WebKit Commit Bot 2014-02-03 13:48:11 PST
All reviewed patches have been landed.  Closing bug.